public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: Mateusz Guzik <mjguzik@gmail.com>,
	Andreas Schwab <schwab@suse.de>, Rich Felker <dalias@libc.org>,
	 Mateusz Guzik via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: fstat(2) penalized by using newfstatat(6, "", buf, AT_EMPTY_PATH)
Date: Tue, 5 Sep 2023 12:21:47 -0700	[thread overview]
Message-ID: <CAHk-=wgfHhF=kZtGmWKckrcbJuO=_gTa=EzMoTeirkRv-3ZR2Q@mail.gmail.com> (raw)
In-Reply-To: <b22fcbd5-eb69-7755-c76a-01706006b3cd@linaro.org>

On Tue, 5 Sept 2023 at 12:17, Adhemerval Zanella Netto
<adhemerval.zanella@linaro.org> wrote:
>
> Below it is the stat logic implemented directly on stat64.c code.

I was looking at that exact thing and going "if this just had
FSTATAT_USE_STATX it would all work easily".

You seem to have fixed that by just moving the FSTATAT_USE_STATX logic
into a common header file.

IOW, this looks good to me.

>     It avoids
> the "flag == AT_EMPTY_PATH ..." check, but it only handles LFS calls
> where statx is not required (so 32 bit architectures will still continue to
> use statx, but I don't think this would be a problem).

I think that given the existing logic, that's exactly the right thing to do.

Let's face it, 32-bit is getting to be pretty irrelevant.

Thanks,

              Linus

  reply	other threads:[~2023-09-05 19:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04  9:55 Mateusz Guzik
2023-09-04 10:08 ` Andreas Schwab
2023-09-04 10:11   ` Mateusz Guzik
2023-09-05 13:01     ` Adhemerval Zanella Netto
2023-09-05 13:14       ` Mateusz Guzik
2023-09-05 17:28         ` Adhemerval Zanella Netto
2023-09-05 17:45           ` Linus Torvalds
2023-09-05 18:22             ` Adhemerval Zanella Netto
2023-09-05 19:16               ` Adhemerval Zanella Netto
2023-09-05 19:21                 ` Linus Torvalds [this message]
2023-09-05 21:42             ` Rich Felker
2023-09-05 21:46               ` Mateusz Guzik
2023-09-05 17:29         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wgfHhF=kZtGmWKckrcbJuO=_gTa=EzMoTeirkRv-3ZR2Q@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=dalias@libc.org \
    --cc=libc-alpha@sourceware.org \
    --cc=mjguzik@gmail.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).