From: Adam Yi <ayi@janestreet.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org, schwab@suse.de, i@adamyi.com
Subject: Re: [PATCH v6] posix: Fix system blocks SIGCHLD erroneously [BZ #30163]
Date: Wed, 8 Mar 2023 16:17:41 +0800 [thread overview]
Message-ID: <CAHwrs-AJQ6QxenhLdWRf3qWKFUk+QCOEnXmYDZHTM72dQ-BymQ@mail.gmail.com> (raw)
In-Reply-To: <49ed5d3-5752-d91c-42ae-f853cbace1d3@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]
Thanks for reporting this! Confirmed that linking with
$(shared-thread-library) fixes the problem. I'll send a patch.
On Wed, Mar 8, 2023 at 6:50 AM Joseph Myers <joseph@codesourcery.com> wrote:
> This breaks the testsuite build for Hurd (tst-system needs to link with
> $(shared-thread-library), I think).
>
> /scratch/jmyers/glibc-bot/install/compilers/i686-gnu/lib/gcc/i686-glibc-gnu/12.2.1/../../../../i686-glibc-gnu/bin/ld:
> /scratch/jmyers/glibc-bot/build/glibcs/i686-gnu/glibc/support/libsupport_nonshared.a(xpthread_create.oS):
> in function `xpthread_create':
> /scratch/jmyers/glibc-bot/src/glibc/support/xpthread_create.c:26:
> undefined reference to `pthread_create'
> /scratch/jmyers/glibc-bot/install/compilers/i686-gnu/lib/gcc/i686-glibc-gnu/12.2.1/../../../../i686-glibc-gnu/bin/ld:
> /scratch/jmyers/glibc-bot/build/glibcs/i686-gnu/glibc/support/libsupport_nonshared.a(xpthread_join.oS):
> in function `xpthread_join':
> /scratch/jmyers/glibc-bot/src/glibc/support/xpthread_join.c:25: undefined
> reference to `pthread_join'
> collect2: error: ld returned 1 exit status
> make[3]: *** [../Rules:238:
> /scratch/jmyers/glibc-bot/build/glibcs/i686-gnu/glibc/stdlib/tst-system]
> Error 1
>
> https://sourceware.org/pipermail/libc-testresults/2023q1/010979.html
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
>
next prev parent reply other threads:[~2023-03-08 8:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 17:31 [PATCH] " Adam Yi
2023-02-24 15:27 ` [PATCH v3] " Adam Yi
2023-03-02 16:42 ` Adhemerval Zanella Netto
2023-03-03 5:11 ` Adam Yi
2023-03-03 12:00 ` Adhemerval Zanella Netto
2023-03-06 4:27 ` [PATCH v4] " Adam Yi
2023-03-06 9:04 ` Andreas Schwab
2023-03-07 1:52 ` [PATCH v5] " Adam Yi
2023-03-07 12:18 ` Adhemerval Zanella Netto
2023-03-07 12:33 ` Florian Weimer
2023-03-07 12:33 ` Adam Yi
2023-03-07 12:30 ` [PATCH v6] " Adam Yi
2023-03-07 12:55 ` Adhemerval Zanella Netto
2023-03-07 22:50 ` Joseph Myers
2023-03-08 8:17 ` Adam Yi [this message]
2023-02-24 18:00 ` [PATCH] " Adam Yi
2023-02-24 20:18 ` Adhemerval Zanella Netto
2023-03-01 2:36 ` Adam Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHwrs-AJQ6QxenhLdWRf3qWKFUk+QCOEnXmYDZHTM72dQ-BymQ@mail.gmail.com \
--to=ayi@janestreet.com \
--cc=adhemerval.zanella@linaro.org \
--cc=i@adamyi.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).