From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: Side effect inside assert macro?
Date: Sat, 25 Mar 2023 12:48:30 -0700 [thread overview]
Message-ID: <CALoOobMLaHVALn-V8g3FXmUxtuRv0eScVT6O9gLnrRJmvHYX6w@mail.gmail.com> (raw)
In-Reply-To: <mvmo7ojwru8.fsf@suse.de>
On Thu, Mar 23, 2023 at 5:54 AM Andreas Schwab via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> In elf/dl-open.c there are two calls to _dl_debug_update inside the
> assert macro:
>
> 581: assert (_dl_debug_update (args->nsid)->r_state == RT_CONSISTENT);
> 930: assert (_dl_debug_update (args.nsid)->r_state == RT_CONSISTENT);
>
> Is it possible that these are the first calls of _dl_debug_update for
> this nsid?
Regardless of whether it's possible or not, this seems like a really
bad idea(TM).
Given that a fix is trivial, why not just fix it?
I'll send a patch.
--
Paul Pluzhnikov
next prev parent reply other threads:[~2023-03-25 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 12:54 Andreas Schwab
2023-03-25 19:48 ` Paul Pluzhnikov [this message]
2023-03-25 21:32 ` [PATCH] Minor: don't call _dl_debug_update (which can have side effects) inside assert Paul Pluzhnikov
2023-03-25 22:09 ` Florian Weimer
2023-03-26 0:24 ` Paul Pluzhnikov
2023-03-26 10:35 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALoOobMLaHVALn-V8g3FXmUxtuRv0eScVT6O9gLnrRJmvHYX6w@mail.gmail.com \
--to=ppluzhnikov@google.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).