From: Andreas Schwab <schwab@suse.de>
To: libc-alpha@sourceware.org
Subject: Side effect inside assert macro?
Date: Thu, 23 Mar 2023 13:54:39 +0100 [thread overview]
Message-ID: <mvmo7ojwru8.fsf@suse.de> (raw)
In elf/dl-open.c there are two calls to _dl_debug_update inside the
assert macro:
581: assert (_dl_debug_update (args->nsid)->r_state == RT_CONSISTENT);
930: assert (_dl_debug_update (args.nsid)->r_state == RT_CONSISTENT);
Is it possible that these are the first calls of _dl_debug_update for
this nsid?
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next reply other threads:[~2023-03-23 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 12:54 Andreas Schwab [this message]
2023-03-25 19:48 ` Paul Pluzhnikov
2023-03-25 21:32 ` [PATCH] Minor: don't call _dl_debug_update (which can have side effects) inside assert Paul Pluzhnikov
2023-03-25 22:09 ` Florian Weimer
2023-03-26 0:24 ` Paul Pluzhnikov
2023-03-26 10:35 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmo7ojwru8.fsf@suse.de \
--to=schwab@suse.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).