Re: [PATCH] Add missing math functions to benchtests

[Sunil Pandey <skpgkp2@gmail.com>]

On Fri, Oct 22, 2021 at 1:39 PM Adhemerval Zanella <
adhemerval.zanella@linaro.org> wrote:

>
>
> On 22/10/2021 16:04, Sunil K Pandey via Libc-alpha wrote:
> > Add acosf, acoshf, asinf, asinhf, atan2f, atanf, atanhf, cbrtf, coshf,
> > erfcf, erff, expm1f, hypotf, log10f, log1pf, sinhf, tanf and tanhf
> > functions to math benchtests.
>
> Please split one patch per function and add a rationale on how each input
> were generate.  Keep in mind that using pure random values might not be
> meaningful (as Joseph has noted for my recent hypot/hypotf one [1].
>
> [1] https://sourceware.org/pipermail/libc-alpha/2021-October/131753.html

Thank you so much for your feedback.
I will split the patch for each function and fix the makefile as suggested.
In this patch, float input file is just a copy of the corresponding double
input file.
Looking for help, how to correctly generate float input files?

> > diff --git a/benchtests/Makefile b/benchtests/Makefile
> > index 4fcd73131a..a250a41664 100644
> > --- a/benchtests/Makefile
> > +++ b/benchtests/Makefile
> > @@ -28,6 +28,9 @@ bench-math := acos acosh asin asinh atan atanh cos
> cosh exp exp2 log log2   \
> >             exp10f ilogb ilogbf cbrt erf erfc exp10 expm1 j0 j1 lgamma
>   \
> >             log10 log1p tgamma y0 y1 atan2
> >
> > +bench-math += acosf acoshf asinf asinhf atan2f atanf atanhf cbrtf coshf
> \
> > +           erfcf erff expm1f hypotf log10f log1pf sinhf tanf tanhf
> > +
> >  ifneq (,$(filter yes,$(float96-fcts)))
> >  bench-math += cbrtl
> >  endif
>
> For new rules I is better one input per line.  In this case:
>
> bench-math += \
>   acosf \
>   acoshf \
>   ...
>   tanhf \
>
> (the last line does have a line continuation, it helps git diff).
>