public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] benchtests: Add small sizes (<= 64) to bench-bzero-walk.c
@ 2022-02-24 17:47 H.J. Lu
  2022-02-24 18:28 ` Sunil Pandey
  0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2022-02-24 17:47 UTC (permalink / raw)
  To: libc-alpha

Small sizes (<= 64) represent large portion of memset usages with zero
value.  Add sizes (<= 64) to bench-bzero-walk.c to cover small sizes.
---
 benchtests/bench-bzero-walk.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/benchtests/bench-bzero-walk.c b/benchtests/bench-bzero-walk.c
index 00226f80b8..4984f6e190 100644
--- a/benchtests/bench-bzero-walk.c
+++ b/benchtests/bench-bzero-walk.c
@@ -113,6 +113,9 @@ test_main (void)
   json_array_end (&json_ctx);
 
   json_array_begin (&json_ctx, "results");
+  for (i = 1; i <= 64; i++)
+    do_test (&json_ctx, i);
+
   for (i = START_SIZE; i <= MIN_PAGE_SIZE; i <<= 1)
     {
       do_test (&json_ctx, i);
-- 
2.35.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] benchtests: Add small sizes (<= 64) to bench-bzero-walk.c
  2022-02-24 17:47 [PATCH] benchtests: Add small sizes (<= 64) to bench-bzero-walk.c H.J. Lu
@ 2022-02-24 18:28 ` Sunil Pandey
  0 siblings, 0 replies; 2+ messages in thread
From: Sunil Pandey @ 2022-02-24 18:28 UTC (permalink / raw)
  To: H.J. Lu; +Cc: GNU C Library, Noah Goldstein

LGTM

Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>

Thanks,
Sunil



On Thu, Feb 24, 2022 at 9:47 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Small sizes (<= 64) represent large portion of memset usages with zero
> value.  Add sizes (<= 64) to bench-bzero-walk.c to cover small sizes.
> ---
>  benchtests/bench-bzero-walk.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/benchtests/bench-bzero-walk.c b/benchtests/bench-bzero-walk.c
> index 00226f80b8..4984f6e190 100644
> --- a/benchtests/bench-bzero-walk.c
> +++ b/benchtests/bench-bzero-walk.c
> @@ -113,6 +113,9 @@ test_main (void)
>    json_array_end (&json_ctx);
>
>    json_array_begin (&json_ctx, "results");
> +  for (i = 1; i <= 64; i++)
> +    do_test (&json_ctx, i);
> +
>    for (i = START_SIZE; i <= MIN_PAGE_SIZE; i <<= 1)
>      {
>        do_test (&json_ctx, i);
> --
> 2.35.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-24 18:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-24 17:47 [PATCH] benchtests: Add small sizes (<= 64) to bench-bzero-walk.c H.J. Lu
2022-02-24 18:28 ` Sunil Pandey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).