public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 1/2] x86-64: Fix strcmp-avx2.S
@ 2022-02-04 19:11 H.J. Lu
  2022-02-04 19:12 ` [PATCH 2/2] x86-64: Fix strcmp-evex.S H.J. Lu
  2022-05-04  5:42 ` [PATCH 1/2] x86-64: Fix strcmp-avx2.S Sunil Pandey
  0 siblings, 2 replies; 4+ messages in thread
From: H.J. Lu @ 2022-02-04 19:11 UTC (permalink / raw)
  To: libc-alpha

Change "movl %edx, %rdx" to "movl %edx, %edx" in:

commit b77b06e0e296f1a2276c27a67e1d44f2cfa38d45
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Mon Jan 10 15:35:38 2022 -0600

    x86: Optimize strcmp-avx2.S
---
 sysdeps/x86_64/multiarch/strcmp-avx2.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
index 28d6a0025a..99e5349be8 100644
--- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
+++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
@@ -106,7 +106,7 @@ ENTRY(STRCMP)
 # ifdef USE_AS_STRNCMP
 #  ifdef __ILP32__
 	/* Clear the upper 32 bits.  */
-	movl	%edx, %rdx
+	movl	%edx, %edx
 #  endif
 	cmp	$1, %RDX_LP
 	/* Signed comparison intentional. We use this branch to also
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] x86-64: Fix strcmp-evex.S
  2022-02-04 19:11 [PATCH 1/2] x86-64: Fix strcmp-avx2.S H.J. Lu
@ 2022-02-04 19:12 ` H.J. Lu
  2022-05-04  5:44   ` Sunil Pandey
  2022-05-04  5:42 ` [PATCH 1/2] x86-64: Fix strcmp-avx2.S Sunil Pandey
  1 sibling, 1 reply; 4+ messages in thread
From: H.J. Lu @ 2022-02-04 19:12 UTC (permalink / raw)
  To: libc-alpha

Change "movl %edx, %rdx" to "movl %edx, %edx" in:

commit 8418eb3ff4b781d31c4ed5dc6c0bd7356bc45db9
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Mon Jan 10 15:35:39 2022 -0600

    x86: Optimize strcmp-evex.S
---
 sysdeps/x86_64/multiarch/strcmp-evex.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
index e5070f3d53..6f42e3155a 100644
--- a/sysdeps/x86_64/multiarch/strcmp-evex.S
+++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
@@ -116,7 +116,7 @@ ENTRY(STRCMP)
 # ifdef USE_AS_STRNCMP
 #  ifdef __ILP32__
 	/* Clear the upper 32 bits.  */
-	movl	%edx, %rdx
+	movl	%edx, %edx
 #  endif
 	cmp	$1, %RDX_LP
 	/* Signed comparison intentional. We use this branch to also
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] x86-64: Fix strcmp-avx2.S
  2022-02-04 19:11 [PATCH 1/2] x86-64: Fix strcmp-avx2.S H.J. Lu
  2022-02-04 19:12 ` [PATCH 2/2] x86-64: Fix strcmp-evex.S H.J. Lu
@ 2022-05-04  5:42 ` Sunil Pandey
  1 sibling, 0 replies; 4+ messages in thread
From: Sunil Pandey @ 2022-05-04  5:42 UTC (permalink / raw)
  To: H.J. Lu, Libc-stable Mailing List; +Cc: GNU C Library

On Fri, Feb 4, 2022 at 11:12 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Change "movl %edx, %rdx" to "movl %edx, %edx" in:
>
> commit b77b06e0e296f1a2276c27a67e1d44f2cfa38d45
> Author: Noah Goldstein <goldstein.w.n@gmail.com>
> Date:   Mon Jan 10 15:35:38 2022 -0600
>
>     x86: Optimize strcmp-avx2.S
> ---
>  sysdeps/x86_64/multiarch/strcmp-avx2.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> index 28d6a0025a..99e5349be8 100644
> --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
> +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
> @@ -106,7 +106,7 @@ ENTRY(STRCMP)
>  # ifdef USE_AS_STRNCMP
>  #  ifdef __ILP32__
>         /* Clear the upper 32 bits.  */
> -       movl    %edx, %rdx
> +       movl    %edx, %edx
>  #  endif
>         cmp     $1, %RDX_LP
>         /* Signed comparison intentional. We use this branch to also
> --
> 2.34.1
>

I would like to backport this patch to release branches.
Any comments or objections?

--Sunil

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] x86-64: Fix strcmp-evex.S
  2022-02-04 19:12 ` [PATCH 2/2] x86-64: Fix strcmp-evex.S H.J. Lu
@ 2022-05-04  5:44   ` Sunil Pandey
  0 siblings, 0 replies; 4+ messages in thread
From: Sunil Pandey @ 2022-05-04  5:44 UTC (permalink / raw)
  To: H.J. Lu, Libc-stable Mailing List; +Cc: GNU C Library

On Fri, Feb 4, 2022 at 11:12 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Change "movl %edx, %rdx" to "movl %edx, %edx" in:
>
> commit 8418eb3ff4b781d31c4ed5dc6c0bd7356bc45db9
> Author: Noah Goldstein <goldstein.w.n@gmail.com>
> Date:   Mon Jan 10 15:35:39 2022 -0600
>
>     x86: Optimize strcmp-evex.S
> ---
>  sysdeps/x86_64/multiarch/strcmp-evex.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> index e5070f3d53..6f42e3155a 100644
> --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> @@ -116,7 +116,7 @@ ENTRY(STRCMP)
>  # ifdef USE_AS_STRNCMP
>  #  ifdef __ILP32__
>         /* Clear the upper 32 bits.  */
> -       movl    %edx, %rdx
> +       movl    %edx, %edx
>  #  endif
>         cmp     $1, %RDX_LP
>         /* Signed comparison intentional. We use this branch to also
> --
> 2.34.1
>

I would like to backport this patch to release branches.
Any comments or objections?

--Sunil

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-05-04  5:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-04 19:11 [PATCH 1/2] x86-64: Fix strcmp-avx2.S H.J. Lu
2022-02-04 19:12 ` [PATCH 2/2] x86-64: Fix strcmp-evex.S H.J. Lu
2022-05-04  5:44   ` Sunil Pandey
2022-05-04  5:42 ` [PATCH 1/2] x86-64: Fix strcmp-avx2.S Sunil Pandey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).