public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: abush wang <abushwangs@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: abushwang via Libc-alpha <libc-alpha@sourceware.org>,
	adhemerval.zanella@linaro.org
Subject: Re: [PATCH] stdlib: reorganize stdlib Makefile routines by functionality
Date: Tue, 2 Apr 2024 10:17:45 +0800	[thread overview]
Message-ID: <CAMLoAPZzAy8Yx6ALRn2BYregSJfFC3QAhEZvDCqB3PQh_7NEFw@mail.gmail.com> (raw)
In-Reply-To: <87plv91b22.fsf@oldenburg3.str.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

Yes,on x86-64.
I just compare the disassemble between d275970ab and before commit by
objdump.
And __drand48_iterate will be more long distance after d275970ab, so I
revert this
commit and found the performance will recover a little.

Thanks,
abush


On Mon, Apr 1, 2024 at 9:12 PM Florian Weimer <fweimer@redhat.com> wrote:

> * abush wang:
>
> > This is test:
> > ```
> > uint64_t getnsecs() {
> >     uint32_t lo, hi;
> >     __asm__ __volatile__ (
> >         "rdtsc" : "=a"(lo), "=d"(hi)
> >     );
> >     return ((uint64_t)hi << 32) | lo;
> > }
> >
> > int main() {
> >     const int num_iterations = 1;
> >     uint64_t start, end, total_time = 0;
> >
> >     start = getnsecs();
> >     for (int i = 0; i < num_iterations; i++) {
> >         (void) lrand48();
> >     }
> >     end = getnsecs();
> >     total_time += (end - start);
> >
> >     printf("Average time for lrand48: %lu cycles\n", total_time /
> num_iterations);
> >     return 0;
> > }
> > ```
> > before:
> > Average time for lrand48: 21418 cycles
> >
> > after:
> > Average time for lrand48: 9892 cycles
>
> Do you see this on x86-64?  So this isn't a displacement range issue?
>
> It could be that this is a random performance change due to code
> alignment, and not actually caused by the direct call distance.
>
> Thanks,
> Florian
>
>

  parent reply	other threads:[~2024-04-02  2:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-01 11:47 abush wang
2024-04-01 13:12 ` Florian Weimer
2024-04-01 13:17   ` H.J. Lu
2024-04-01 13:46     ` Adhemerval Zanella Netto
2024-04-02  3:54     ` abush wang
2024-04-08  2:48       ` abush wang
2024-04-02  2:17   ` abush wang [this message]
2024-04-02  2:28     ` abush wang
2024-04-02  3:13       ` H.J. Lu
2024-04-02  6:18         ` abush wang
2024-04-02 14:15 ` Adhemerval Zanella Netto
2024-04-03  1:57   ` abush wang
  -- strict thread matches above, loose matches on Subject: below --
2024-04-01 11:44 abushwang
2024-04-01 12:03 ` Xi Ruoyao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMLoAPZzAy8Yx6ALRn2BYregSJfFC3QAhEZvDCqB3PQh_7NEFw@mail.gmail.com \
    --to=abushwangs@gmail.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).