[PATCH] elf: Copy l_addr/l_ld when adding ld.so to a new namespace

[PATCH] elf: Copy l_addr/l_ld when adding ld.so to a new namespace

[H.J. Lu]

When add ld.so to a new namespace, we don't actually load ld.so.  We
create a new link map and refers the real one for almost everything.
Copy l_addr and l_ld from the real ld.so link map to avoid GDB warning:

warning: .dynamic section for ".../elf/ld-linux-x86-64.so.2" is not at the expected address (wrong library or version mismatch?)

when handling shared library loaded by dlmopen.
---
 elf/dl-load.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/elf/dl-load.c b/elf/dl-load.c
index cb0618b7fc..aab290bea6 100644
--- a/elf/dl-load.c
+++ b/elf/dl-load.c
@@ -1026,6 +1026,10 @@ _dl_map_object_from_fd (const char *name, const char *origname, int fd,
       /* Refer to the real descriptor.  */
       l->l_real = &GL(dl_rtld_map);
 
+      /* Also copy l_addr and l_ld.  */
+      l->l_addr = l->l_real->l_addr;
+      l->l_ld = l->l_real->l_ld;
+
       /* No need to bump the refcount of the real object, ld.so will
 	 never be unloaded.  */
       __close_nocancel (fd);
-- 
2.31.1

PING^1 [PATCH] elf: Copy l_addr/l_ld when adding ld.so to a new namespace

[H.J. Lu]

On Tue, Aug 17, 2021 at 7:28 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> When add ld.so to a new namespace, we don't actually load ld.so.  We
> create a new link map and refers the real one for almost everything.
> Copy l_addr and l_ld from the real ld.so link map to avoid GDB warning:
>
> warning: .dynamic section for ".../elf/ld-linux-x86-64.so.2" is not at the expected address (wrong library or version mismatch?)
>
> when handling shared library loaded by dlmopen.
> ---
>  elf/dl-load.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/elf/dl-load.c b/elf/dl-load.c
> index cb0618b7fc..aab290bea6 100644
> --- a/elf/dl-load.c
> +++ b/elf/dl-load.c
> @@ -1026,6 +1026,10 @@ _dl_map_object_from_fd (const char *name, const char *origname, int fd,
>        /* Refer to the real descriptor.  */
>        l->l_real = &GL(dl_rtld_map);
>
> +      /* Also copy l_addr and l_ld.  */
> +      l->l_addr = l->l_real->l_addr;
> +      l->l_ld = l->l_real->l_ld;
> +
>        /* No need to bump the refcount of the real object, ld.so will
>          never be unloaded.  */
>        __close_nocancel (fd);
> --
> 2.31.1
>

PING.

-- 
H.J.

PING^2 [PATCH] elf: Copy l_addr/l_ld when adding ld.so to a new namespace

[H.J. Lu]

On Mon, Sep 20, 2021 at 9:52 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Tue, Aug 17, 2021 at 7:28 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > When add ld.so to a new namespace, we don't actually load ld.so.  We
> > create a new link map and refers the real one for almost everything.
> > Copy l_addr and l_ld from the real ld.so link map to avoid GDB warning:
> >
> > warning: .dynamic section for ".../elf/ld-linux-x86-64.so.2" is not at the expected address (wrong library or version mismatch?)
> >
> > when handling shared library loaded by dlmopen.
> > ---
> >  elf/dl-load.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/elf/dl-load.c b/elf/dl-load.c
> > index cb0618b7fc..aab290bea6 100644
> > --- a/elf/dl-load.c
> > +++ b/elf/dl-load.c
> > @@ -1026,6 +1026,10 @@ _dl_map_object_from_fd (const char *name, const char *origname, int fd,
> >        /* Refer to the real descriptor.  */
> >        l->l_real = &GL(dl_rtld_map);
> >
> > +      /* Also copy l_addr and l_ld.  */
> > +      l->l_addr = l->l_real->l_addr;
> > +      l->l_ld = l->l_real->l_ld;
> > +
> >        /* No need to bump the refcount of the real object, ld.so will
> >          never be unloaded.  */
> >        __close_nocancel (fd);
> > --
> > 2.31.1
> >
>
> PING.
>

Any comments on this patch?

-- 
H.J.

Re: [PATCH] elf: Copy l_addr/l_ld when adding ld.so to a new namespace

[Adhemerval Zanella]

On 17/08/2021 23:28, H.J. Lu via Libc-alpha wrote:
> When add ld.so to a new namespace, we don't actually load ld.so.  We
> create a new link map and refers the real one for almost everything.
> Copy l_addr and l_ld from the real ld.so link map to avoid GDB warning:
> 
> warning: .dynamic section for ".../elf/ld-linux-x86-64.so.2" is not at the expected address (wrong library or version mismatch?)
> 
> when handling shared library loaded by dlmopen.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  elf/dl-load.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/elf/dl-load.c b/elf/dl-load.c
> index cb0618b7fc..aab290bea6 100644
> --- a/elf/dl-load.c
> +++ b/elf/dl-load.c
> @@ -1026,6 +1026,10 @@ _dl_map_object_from_fd (const char *name, const char *origname, int fd,
>        /* Refer to the real descriptor.  */
>        l->l_real = &GL(dl_rtld_map);
>  
> +      /* Also copy l_addr and l_ld.  */

This comments seems obvious, maybe add it is required to avoid a
GDB warning with dlmopen();

> +      l->l_addr = l->l_real->l_addr;
> +      l->l_ld = l->l_real->l_ld;
> +
>        /* No need to bump the refcount of the real object, ld.so will
>  	 never be unloaded.  */
>        __close_nocancel (fd);
> 

Re: [PATCH] elf: Copy l_addr/l_ld when adding ld.so to a new namespace

[H.J. Lu]

[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]

On Wed, Sep 29, 2021 at 11:57 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> On 17/08/2021 23:28, H.J. Lu via Libc-alpha wrote:
> > When add ld.so to a new namespace, we don't actually load ld.so.  We
> > create a new link map and refers the real one for almost everything.
> > Copy l_addr and l_ld from the real ld.so link map to avoid GDB warning:
> >
> > warning: .dynamic section for ".../elf/ld-linux-x86-64.so.2" is not at the expected address (wrong library or version mismatch?)
> >
> > when handling shared library loaded by dlmopen.
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
>
> > ---
> >  elf/dl-load.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/elf/dl-load.c b/elf/dl-load.c
> > index cb0618b7fc..aab290bea6 100644
> > --- a/elf/dl-load.c
> > +++ b/elf/dl-load.c
> > @@ -1026,6 +1026,10 @@ _dl_map_object_from_fd (const char *name, const char *origname, int fd,
> >        /* Refer to the real descriptor.  */
> >        l->l_real = &GL(dl_rtld_map);
> >
> > +      /* Also copy l_addr and l_ld.  */
>
> This comments seems obvious, maybe add it is required to avoid a
> GDB warning with dlmopen();

Changed to

/* Copy l_addr and l_ld to avoid a GDB warning with dlmopen().  */

> > +      l->l_addr = l->l_real->l_addr;
> > +      l->l_ld = l->l_real->l_ld;
> > +
> >        /* No need to bump the refcount of the real object, ld.so will
> >        never be unloaded.  */
> >        __close_nocancel (fd);
> >

This is the patch I am checking in.

Thanks.

-- 
H.J.

[-- Attachment #2: 0001-elf-Copy-l_addr-l_ld-when-adding-ld.so-to-a-new-name.patch --]
[-- Type: text/x-patch, Size: 1324 bytes --]

From bb4cf09c2699cdc8e5380598dc8075dfa19203d1 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 17 Aug 2021 19:36:04 -0700
Subject: [PATCH] elf: Copy l_addr/l_ld when adding ld.so to a new namespace

When add ld.so to a new namespace, we don't actually load ld.so.  We
create a new link map and refers the real one for almost everything.
Copy l_addr and l_ld from the real ld.so link map to avoid GDB warning:

warning: .dynamic section for ".../elf/ld-linux-x86-64.so.2" is not at the expected address (wrong library or version mismatch?)

when handling shared library loaded by dlmopen.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
---
 elf/dl-load.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/elf/dl-load.c b/elf/dl-load.c
index 6ea71077af..99c5ab83b3 100644
--- a/elf/dl-load.c
+++ b/elf/dl-load.c
@@ -1026,6 +1026,10 @@ _dl_map_object_from_fd (const char *name, const char *origname, int fd,
       /* Refer to the real descriptor.  */
       l->l_real = &GL(dl_rtld_map);
 
+      /* Copy l_addr and l_ld to avoid a GDB warning with dlmopen().  */
+      l->l_addr = l->l_real->l_addr;
+      l->l_ld = l->l_real->l_ld;
+
       /* No need to bump the refcount of the real object, ld.so will
 	 never be unloaded.  */
       __close_nocancel (fd);
-- 
2.31.1