public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Martin Sebor <msebor@gmail.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
	Florian Weimer <fweimer@redhat.com>,
	Martin Sebor via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] add attribute none to pthread_setspecific (BZ #27714)
Date: Tue, 27 Apr 2021 18:30:27 -0700	[thread overview]
Message-ID: <CAMe9rOoONEQLTP1BN222_cuS2MxgVpA8+ATVvrpgVQyQW4t2MQ@mail.gmail.com> (raw)
In-Reply-To: <47fc35d1-05b0-c02e-77dc-b3193aefd865@gmail.com>

On Tue, Apr 27, 2021 at 6:00 PM Martin Sebor via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On 4/27/21 3:58 PM, Joseph Myers wrote:
> > On Tue, 27 Apr 2021, Martin Sebor via Libc-alpha wrote:
> >
> >> These are warnings in my build (I've seen a few others scroll by
> >> and have always assumed they were expected(*)).  Those you pasted
> >
> > Most warnings are errors by default (unless you use --disable-werror,
> > which should never normally be used in glibc development unless you're
> > e.g. reviewing the warnings you get if you add extra warning options to
> > those with which glibc is built by default, in order to fix those warnings
> > before adding the extra options).
>
> Ah, that's what my build script does and I keep forgetting to
> change that when working on Glibc (as opposed to testing new
> GCC warnings).  My bad.  The attached diff patches up the tests
> to pass the function a valid argument.  I'll plan to commit it
> shortly unless you prefer some other solution.
>

It doesn't work:

https://sourceware.org/bugzilla/show_bug.cgi?id=27714#c3

-- 
H.J.

      parent reply	other threads:[~2021-04-28  1:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 21:30 Martin Sebor
2021-04-22 22:26 ` Martin Sebor
2021-04-23  0:11 ` Paul Eggert
2021-04-23 15:24   ` Martin Sebor
2021-04-23 20:19     ` Paul Eggert
2021-04-23 21:29       ` Martin Sebor
2021-04-24  0:27         ` Paul Eggert
2021-04-26 19:38           ` Martin Sebor
2021-04-27  4:41 ` Florian Weimer
2021-04-27 19:07   ` Martin Sebor
2021-04-27 21:07     ` Joseph Myers
2021-04-27 21:46       ` Martin Sebor
2021-04-27 21:58         ` Joseph Myers
2021-04-27 22:57           ` Martin Sebor
2021-04-28  1:09             ` Martin Sebor
2021-04-28  7:32               ` Florian Weimer
2021-04-28 14:49                 ` Martin Sebor
2021-04-29  7:45                   ` Florian Weimer
2021-04-29 14:55                     ` Martin Sebor
2021-04-29 16:16                       ` Florian Weimer
2021-04-28  1:30             ` H.J. Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOoONEQLTP1BN222_cuS2MxgVpA8+ATVvrpgVQyQW4t2MQ@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=msebor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).