* [PATCH v3] Improve test coverage of strnlen function
@ 2021-06-02 22:29 Sunil K Pandey
2021-06-02 23:14 ` Noah Goldstein
2021-06-03 16:58 ` H.J. Lu
0 siblings, 2 replies; 3+ messages in thread
From: Sunil K Pandey @ 2021-06-02 22:29 UTC (permalink / raw)
To: libc-alpha
This patch covers the following condition:
Strings start with different alignments and end with length less than or
equal to 512 byte.
---
string/test-strnlen.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/string/test-strnlen.c b/string/test-strnlen.c
index d70faa26ab..920f58e97b 100644
--- a/string/test-strnlen.c
+++ b/string/test-strnlen.c
@@ -230,7 +230,7 @@ do_page_2_tests (void)
int
test_main (void)
{
- size_t i;
+ size_t i, length, char_per_page;
test_init ();
@@ -271,6 +271,15 @@ test_main (void)
do_test (1, 1 << i, 5000, BIG_CHAR);
}
+ char_per_page = getpagesize () / sizeof (CHAR);
+
+ for (i = 0; i <= 127; i++)
+ for (length = i; length <= 512; length++)
+ {
+ do_test (i, length, 512, BIG_CHAR);
+ do_test (char_per_page - i, length, 512, BIG_CHAR);
+ }
+
do_random_tests ();
do_page_tests ();
do_page_2_tests ();
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Improve test coverage of strnlen function
2021-06-02 22:29 [PATCH v3] Improve test coverage of strnlen function Sunil K Pandey
@ 2021-06-02 23:14 ` Noah Goldstein
2021-06-03 16:58 ` H.J. Lu
1 sibling, 0 replies; 3+ messages in thread
From: Noah Goldstein @ 2021-06-02 23:14 UTC (permalink / raw)
To: Sunil K Pandey; +Cc: GNU C Library
On Wed, Jun 2, 2021 at 6:30 PM Sunil K Pandey via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> This patch covers the following condition:
>
> Strings start with different alignments and end with length less than or
> equal to 512 byte.
> ---
> string/test-strnlen.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/string/test-strnlen.c b/string/test-strnlen.c
> index d70faa26ab..920f58e97b 100644
> --- a/string/test-strnlen.c
> +++ b/string/test-strnlen.c
> @@ -230,7 +230,7 @@ do_page_2_tests (void)
> int
> test_main (void)
> {
> - size_t i;
> + size_t i, length, char_per_page;
>
> test_init ();
>
> @@ -271,6 +271,15 @@ test_main (void)
> do_test (1, 1 << i, 5000, BIG_CHAR);
> }
>
> + char_per_page = getpagesize () / sizeof (CHAR);
> +
> + for (i = 0; i <= 127; i++)
> + for (length = i; length <= 512; length++)
> + {
> + do_test (i, length, 512, BIG_CHAR);
> + do_test (char_per_page - i, length, 512, BIG_CHAR);
> + }
> +
> do_random_tests ();
> do_page_tests ();
> do_page_2_tests ();
> --
> 2.31.1
>
LGTM. Think a maintainer needs to make the final call
though.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Improve test coverage of strnlen function
2021-06-02 22:29 [PATCH v3] Improve test coverage of strnlen function Sunil K Pandey
2021-06-02 23:14 ` Noah Goldstein
@ 2021-06-03 16:58 ` H.J. Lu
1 sibling, 0 replies; 3+ messages in thread
From: H.J. Lu @ 2021-06-03 16:58 UTC (permalink / raw)
To: Sunil K Pandey; +Cc: GNU C Library
On Wed, Jun 2, 2021 at 3:29 PM Sunil K Pandey <skpgkp2@gmail.com> wrote:
>
> This patch covers the following condition:
>
> Strings start with different alignments and end with length less than or
> equal to 512 byte.
> ---
> string/test-strnlen.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/string/test-strnlen.c b/string/test-strnlen.c
> index d70faa26ab..920f58e97b 100644
> --- a/string/test-strnlen.c
> +++ b/string/test-strnlen.c
> @@ -230,7 +230,7 @@ do_page_2_tests (void)
> int
> test_main (void)
> {
> - size_t i;
> + size_t i, length, char_per_page;
>
> test_init ();
>
> @@ -271,6 +271,15 @@ test_main (void)
> do_test (1, 1 << i, 5000, BIG_CHAR);
> }
>
> + char_per_page = getpagesize () / sizeof (CHAR);
> +
> + for (i = 0; i <= 127; i++)
> + for (length = i; length <= 512; length++)
> + {
> + do_test (i, length, 512, BIG_CHAR);
> + do_test (char_per_page - i, length, 512, BIG_CHAR);
> + }
> +
> do_random_tests ();
> do_page_tests ();
> do_page_2_tests ();
> --
> 2.31.1
>
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-03 16:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02 22:29 [PATCH v3] Improve test coverage of strnlen function Sunil K Pandey
2021-06-02 23:14 ` Noah Goldstein
2021-06-03 16:58 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).