From: "H.J. Lu" <hjl.tools@gmail.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Fangrui Song <maskray@google.com>
Subject: Re: [PATCH] i386: Use fldt instead of fld on e_logl.S
Date: Thu, 4 Aug 2022 14:23:38 -0700 [thread overview]
Message-ID: <CAMe9rOojUXB1aoOPjd-Ed_XghoOiWjEzSK-qwGJmOziKib4LrA@mail.gmail.com> (raw)
In-Reply-To: <20220804210016.2613403-1-adhemerval.zanella@linaro.org>
On Thu, Aug 4, 2022 at 2:00 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> Clang cannot assemble fldt in the AT&T dialect mode.
> ---
> sysdeps/i386/i686/fpu/e_logl.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sysdeps/i386/i686/fpu/e_logl.S b/sysdeps/i386/i686/fpu/e_logl.S
> index 63183ac544..5d53f3bb22 100644
> --- a/sysdeps/i386/i686/fpu/e_logl.S
> +++ b/sysdeps/i386/i686/fpu/e_logl.S
> @@ -43,7 +43,7 @@ ENTRY(__ieee754_logl)
> fsubl MO(one) // x-1 : x : log(2)
> 5: fld %st // x-1 : x-1 : x : log(2)
> fabs // |x-1| : x-1 : x : log(2)
> - fld MO(limit) // 0.29 : |x-1| : x-1 : x : log(2)
> + fldt MO(limit) // 0.29 : |x-1| : x-1 : x : log(2)
> fcomip %st(1) // |x-1| : x-1 : x : log(2)
> fstp %st(0) // x-1 : x : log(2)
> jc 2f
> @@ -76,7 +76,7 @@ ENTRY(__logl_finite)
> fsubl MO(one) // x-1 : x : log(2)
> fld %st // x-1 : x-1 : x : log(2)
> fabs // |x-1| : x-1 : x : log(2)
> - fld MO(limit) // 0.29 : |x-1| : x-1 : x : log(2)
> + fldt MO(limit) // 0.29 : |x-1| : x-1 : x : log(2)
> fcomip %st(1) // |x-1| : x-1 : x : log(2)
> fstp %st(0) // x-1 : x : log(2)
> jc 2b
> --
> 2.34.1
>
I don't think this is correct since there are
.type limit,@object
limit: .double 0.29
It should be fldl.
--
H.J.
next prev parent reply other threads:[~2022-08-04 21:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 21:00 Adhemerval Zanella
2022-08-04 21:23 ` H.J. Lu [this message]
2022-08-04 21:31 ` Fangrui Song
2022-08-04 21:35 ` H.J. Lu
2022-08-05 12:28 ` Adhemerval Zanella Netto
2022-08-05 16:55 ` H.J. Lu
2022-08-05 17:23 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOojUXB1aoOPjd-Ed_XghoOiWjEzSK-qwGJmOziKib4LrA@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).