From: "H.J. Lu" <hjl.tools@gmail.com>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
"Carlos O'Donell" <carlos@systemhalted.org>
Subject: Re: [PATCH v1] x86_64: Add memcmpeq.S to fix disable-multi-arch build
Date: Thu, 28 Oct 2021 13:39:52 -0700 [thread overview]
Message-ID: <CAMe9rOp2=rO6rUjDEMMo8A=gj5aH+sFbzqGS0VOpD+B56UekrA@mail.gmail.com> (raw)
In-Reply-To: <CAFUsyfJE+DmBmxZD6Y8YKdzEvMssZtKysrHOksMEPBu7nU31Kw@mail.gmail.com>
On Thu, Oct 28, 2021 at 1:22 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Thu, Oct 28, 2021 at 3:19 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Thu, Oct 28, 2021 at 12:47 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > The following commit:
> > >
> > > commit cf4fd28ea453d1a9cec93939bc88b58ccef5437a
> > > Author: Noah Goldstein <goldstein.w.n@gmail.com>
> > > Date: Tue Oct 26 19:43:18 2021 -0500
> > >
> > > Broke --disable-multi-arch build for x86_64 because x86_64/memcmpeq.S
> > > was not defined outside of multiarch and the alias for __memcmpeq in
> > > x86_64/memcmp.S was removed.
> > >
> > > This commit fixes that issue by adding x86_64/memcmpeq.S.
> > >
> > > make xcheck passes on x86_64 with and without --disable-multi-arch
> > > ---
> > > sysdeps/x86_64/memcmpeq.S | 23 +++++++++++++++++++++++
> > > 1 file changed, 23 insertions(+)
> > > create mode 100644 sysdeps/x86_64/memcmpeq.S
> > >
> > > diff --git a/sysdeps/x86_64/memcmpeq.S b/sysdeps/x86_64/memcmpeq.S
> > > new file mode 100644
> > > index 0000000000..f3dd1d0085
> > > --- /dev/null
> > > +++ b/sysdeps/x86_64/memcmpeq.S
> > > @@ -0,0 +1,23 @@
> > > +/* __memcmpeq optimized with SSE2.
> > > + Copyright (C) 2017-2021 Free Software Foundation, Inc.
> > > + This file is part of the GNU C Library.
> > > +
> > > + The GNU C Library is free software; you can redistribute it and/or
> > > + modify it under the terms of the GNU Lesser General Public
> > > + License as published by the Free Software Foundation; either
> > > + version 2.1 of the License, or (at your option) any later version.
> > > +
> > > + The GNU C Library is distributed in the hope that it will be useful,
> > > + but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > > + Lesser General Public License for more details.
> > > +
> > > + You should have received a copy of the GNU Lesser General Public
> > > + License along with the GNU C Library; if not, see
> > > + <https://www.gnu.org/licenses/>. */
> > > +
> > > +#ifndef memcmp
> > > +# define memcmp __memcmpeq
> > > +#endif
> >
> > Why is this needed? Does the simple
> >
> > #define memcmp __memcmpeq
> >
> > work?
>
> It's not inherently needed.
>
> Generally just think it's easier to protect these
> definitions so it's easier to include the file.
>
> Do you want me to remove it?
Yes, please remove it. OK with that change.
Thanks.
> >
> > > +#define USE_AS_MEMCMPEQ 1
> > > +#include "multiarch/memcmp-sse2.S"
> > > --
> > > 2.25.1
> > >
> >
> >
> > --
> > H.J.
--
H.J.
next prev parent reply other threads:[~2021-10-28 20:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 19:47 Noah Goldstein
2021-10-28 20:19 ` H.J. Lu
2021-10-28 20:22 ` Noah Goldstein
2021-10-28 20:39 ` H.J. Lu [this message]
2021-10-28 21:11 ` Noah Goldstein
2021-10-28 21:10 ` [PATCH v2] " Noah Goldstein
2021-10-28 21:14 ` H.J. Lu
2021-10-28 21:36 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOp2=rO6rUjDEMMo8A=gj5aH+sFbzqGS0VOpD+B56UekrA@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=carlos@systemhalted.org \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).