From: "H.J. Lu" <hjl.tools@gmail.com>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 05/19] <sys/platform/x86.h>: Add SGX-KEYS support
Date: Wed, 5 Apr 2023 11:39:32 -0700 [thread overview]
Message-ID: <CAMe9rOp=ouPsU-cH9pUg5vNX=QUgiLLu55SVXZ+hVxygV_W-MQ@mail.gmail.com> (raw)
In-Reply-To: <CAFUsyfJUXTM3z8VWYsJS8WHu8qLaW6E1LbvnqmesFymde9CoVA@mail.gmail.com>
On Wed, Apr 5, 2023 at 11:21 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Wed, Apr 5, 2023 at 11:25 AM H.J. Lu via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
> >
> > Add SGX-KEYS support to <sys/platform/x86.h>.
> > ---
> > manual/platform.texi | 3 +++
> > sysdeps/x86/bits/platform/x86.h | 2 +-
> > sysdeps/x86/tst-get-cpu-features.c | 1 +
> > 3 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/manual/platform.texi b/manual/platform.texi
> > index 78ee39f650..4453f6e1f4 100644
> > --- a/manual/platform.texi
> > +++ b/manual/platform.texi
> > @@ -551,6 +551,9 @@ capability.
> > @item
> > @code{SGX} -- Intel Software Guard Extensions.
> >
> > +@item
> > +@code{SGX_KEYS} -- Attestation Services for SGX.
> > +
> > @item
> > @code{SGX_LC} -- SGX Launch Configuration.
> >
> > diff --git a/sysdeps/x86/bits/platform/x86.h b/sysdeps/x86/bits/platform/x86.h
> > index e25f1ac53c..ee5be8190f 100644
> > --- a/sysdeps/x86/bits/platform/x86.h
> > +++ b/sysdeps/x86/bits/platform/x86.h
> > @@ -201,7 +201,7 @@ enum
> > + cpuid_register_index_edx * 8 * sizeof (unsigned int)),
> >
> > x86_cpu_INDEX_7_EDX_0 = x86_cpu_index_7_edx,
> > - x86_cpu_INDEX_7_EDX_1 = x86_cpu_index_7_edx + 1,
> > + x86_cpu_SGX_KEYS = x86_cpu_index_7_edx + 1,
> > x86_cpu_AVX512_4VNNIW = x86_cpu_index_7_edx + 2,
> > x86_cpu_AVX512_4FMAPS = x86_cpu_index_7_edx + 3,
> > x86_cpu_FSRM = x86_cpu_index_7_edx + 4,
> > diff --git a/sysdeps/x86/tst-get-cpu-features.c b/sysdeps/x86/tst-get-cpu-features.c
> > index dcb735ddd6..1979da2174 100644
> > --- a/sysdeps/x86/tst-get-cpu-features.c
> > +++ b/sysdeps/x86/tst-get-cpu-features.c
> > @@ -154,6 +154,7 @@ do_test (void)
> > CHECK_CPU_FEATURE_PRESENT (ENQCMD);
> > CHECK_CPU_FEATURE_PRESENT (SGX_LC);
> > CHECK_CPU_FEATURE_PRESENT (PKS);
> > + CHECK_CPU_FEATURE_PRESENT (SGX_KEYS);
> > CHECK_CPU_FEATURE_PRESENT (AVX512_4VNNIW);
> > CHECK_CPU_FEATURE_PRESENT (AVX512_4FMAPS);
> > CHECK_CPU_FEATURE_PRESENT (FSRM);
> > --
> > 2.39.2
> >
>
> Rename 'bit_cpu_INDEX_7_EDX_1' in cpu-features.h?
> Likewise for all other patches that don't rename the new index.
They can't be removed since they aren't used by
CPU_FEATURE_SET_ACTIVE.
--
H.J.
next prev parent reply other threads:[~2023-04-05 18:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 16:21 [PATCH 00/19] <sys/platform/x86.h>: Update CPUID features H.J. Lu
2023-04-05 16:21 ` [PATCH 01/19] <bits/platform/x86.h>: Rename to x86_cpu_INDEX_7_ECX_15 H.J. Lu
2023-04-05 21:02 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 02/19] platform.texi: Move LAM after LAHF64_SAHF64 H.J. Lu
2023-04-05 21:02 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 03/19] <sys/platform/x86.h>: Add LA57 support H.J. Lu
2023-04-05 18:19 ` Noah Goldstein
2023-04-05 18:38 ` H.J. Lu
2023-04-05 21:02 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 04/19] <sys/platform/x86.h>: Add BUS_LOCK_DETECT support H.J. Lu
2023-04-05 18:20 ` Noah Goldstein
2023-04-05 21:03 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 05/19] <sys/platform/x86.h>: Add SGX-KEYS support H.J. Lu
2023-04-05 18:21 ` Noah Goldstein
2023-04-05 18:39 ` H.J. Lu [this message]
2023-04-05 21:03 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 06/19] <sys/platform/x86.h>: Add RTM_FORCE_ABORT support H.J. Lu
2023-04-05 21:03 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 07/19] <sys/platform/x86.h>: Add LBR support H.J. Lu
2023-04-05 21:03 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 08/19] <sys/platform/x86.h>: Add RAO-INT support H.J. Lu
2023-04-05 21:03 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 09/19] <sys/platform/x86.h>: Add LASS support H.J. Lu
2023-04-05 21:04 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 10/19] <sys/platform/x86.h>: Add CMPCCXADD support H.J. Lu
2023-04-05 21:04 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 11/19] <sys/platform/x86.h>: Add ArchPerfmonExt support H.J. Lu
2023-04-05 21:04 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 12/19] <sys/platform/x86.h>: Add WRMSRNS support H.J. Lu
2023-04-05 21:04 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 13/19] <sys/platform/x86.h>: Add AMX-FP16 support H.J. Lu
2023-04-05 21:04 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 14/19] <sys/platform/x86.h>: Add AVX-IFMA support H.J. Lu
2023-04-05 21:05 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 15/19] <sys/platform/x86.h>: Add MSRLIST support H.J. Lu
2023-04-05 21:05 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 16/19] <sys/platform/x86.h>: Add AVX-VNNI-INT8 support H.J. Lu
2023-04-05 21:05 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 17/19] <sys/platform/x86.h>: Add AVX-NE-CONVERT support H.J. Lu
2023-04-05 21:05 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 18/19] <sys/platform/x86.h>: Add AMX-COMPLEX support H.J. Lu
2023-04-05 21:05 ` Noah Goldstein
2023-04-05 16:21 ` [PATCH 19/19] <sys/platform/x86.h>: Add PREFETCHI support H.J. Lu
2023-04-05 21:05 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOp=ouPsU-cH9pUg5vNX=QUgiLLu55SVXZ+hVxygV_W-MQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).