From: "H.J. Lu" <hjl.tools@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Remove the unnecessary +make-deps
Date: Mon, 8 Nov 2021 10:42:56 -0800 [thread overview]
Message-ID: <CAMe9rOpWZucZN01KF-ffK=J95kuGzPVtvbRMmxjVP2hVCknwZA@mail.gmail.com> (raw)
In-Reply-To: <87cznay6to.fsf@igel.home>
On Mon, Nov 8, 2021 at 8:01 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Nov 06 2021, H.J. Lu via Libc-alpha wrote:
>
> > diff --git a/Makerules b/Makerules
> > index 3503605a8e..8db0ca1296 100644
> > --- a/Makerules
> > +++ b/Makerules
> > @@ -459,15 +459,6 @@ compile-stdin.c = $(COMPILE.c) -o $@ -x c - $(compile-mkdep-flags)
> > # get the wrong predefines.
> > S-CPPFLAGS = -DASSEMBLER $(asm-CPPFLAGS)
> >
> > -define +make-deps
> > -$(make-target-directory)
> > -$(+mkdep) $< $(if $(filter %.c,$<),$(CFLAGS)) \
>
> This was the last use of +mkdep.
>
> > diff --git a/sysdeps/unix/Makefile b/sysdeps/unix/Makefile
> > index 2ee3be7237..582baa4bd8 100644
> > --- a/sysdeps/unix/Makefile
> > +++ b/sysdeps/unix/Makefile
> > @@ -104,10 +104,6 @@ $(common-objpfx)sysd-syscalls: $(..)sysdeps/unix/make-syscalls.sh \
> > mv -f $@T $@
> > endif
> >
> > -$(common-objpfx)s-%.d: $(..)sysdeps/unix/s-%.S \
> > - $(wildcard $(+sysdep_dirs:%=%/syscalls.list))
>
> This was the last reference to sysdeps/unix/s-proto.S and
> sysdeps/unix/s-proto-cancel.S.
>
> Andreas.
>
The v2 patch is at
https://sourceware.org/pipermail/libc-alpha/2021-November/132816.html
--
H.J.
prev parent reply other threads:[~2021-11-08 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 13:50 H.J. Lu
2021-11-08 16:01 ` Andreas Schwab
2021-11-08 16:12 ` H.J. Lu
2021-11-08 18:42 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOpWZucZN01KF-ffK=J95kuGzPVtvbRMmxjVP2hVCknwZA@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).