* [PATCH] Fix error message in memmove test to display correct src pointer
@ 2021-08-26 15:48 Sunil K Pandey
2021-08-26 16:21 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: Sunil K Pandey @ 2021-08-26 15:48 UTC (permalink / raw)
To: libc-alpha
---
string/test-memmove.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/string/test-memmove.c b/string/test-memmove.c
index 670094c9dc..02f2170bfd 100644
--- a/string/test-memmove.c
+++ b/string/test-memmove.c
@@ -298,7 +298,7 @@ do_test2 (size_t offset)
{
error (0, 0,
"Wrong result in function %s dst \"%p\" src \"%p\" offset \"%zd\"",
- impl->name, dst, large_buf, i);
+ impl->name, dst, src, i);
ret = 1;
munmap ((void *) large_buf, size);
return;
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix error message in memmove test to display correct src pointer
2021-08-26 15:48 [PATCH] Fix error message in memmove test to display correct src pointer Sunil K Pandey
@ 2021-08-26 16:21 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2021-08-26 16:21 UTC (permalink / raw)
To: Sunil K Pandey; +Cc: GNU C Library
On Thu, Aug 26, 2021 at 8:49 AM Sunil K Pandey <skpgkp2@gmail.com> wrote:
>
> ---
> string/test-memmove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/string/test-memmove.c b/string/test-memmove.c
> index 670094c9dc..02f2170bfd 100644
> --- a/string/test-memmove.c
> +++ b/string/test-memmove.c
> @@ -298,7 +298,7 @@ do_test2 (size_t offset)
> {
> error (0, 0,
> "Wrong result in function %s dst \"%p\" src \"%p\" offset \"%zd\"",
> - impl->name, dst, large_buf, i);
> + impl->name, dst, src, i);
large_buf == source is true only in the first iteration.
> ret = 1;
> munmap ((void *) large_buf, size);
> return;
> --
> 2.31.1
>
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-26 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-26 15:48 [PATCH] Fix error message in memmove test to display correct src pointer Sunil K Pandey
2021-08-26 16:21 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).