From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] elf: Use a temporary file to generate Makefile fragments [BZ #28550]
Date: Wed, 17 Nov 2021 07:39:01 -0800 [thread overview]
Message-ID: <CAMe9rOpYhDxSfOP0tAq7eb1wJ-Vy0RZy5iP6ZrSEEPDWsq8adw@mail.gmail.com> (raw)
In-Reply-To: <87h7ca6brq.fsf@oldenburg.str.redhat.com>
On Wed, Nov 17, 2021 at 7:29 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu:
>
> > On Wed, Nov 17, 2021 at 5:49 AM Florian Weimer <fweimer@redhat.com> wrote:
> >>
> >> I still see
> >>
> >> /builddir/build/BUILD/glibc-2.34.9000-294-ga43c0b5483/build-x86_64-redhat-linux/elf/dso-sort-tests-2.def.generated-makefile:1067: warning: overriding recipe for target '/builddir/build/BUILD/glibc-2.34.9000-294-ga43c0b5483/build-x86_64-redhat-linux/elf/tst-redhat-1162810-dir/tst-redhat-1162810-M22X17.os'
> >>
> >> and eventually a build failure:
> >>
> >> make[2]: Leaving directory '/builddir/build/BUILD/glibc-2.34.9000-294-ga43c0b5483/elf'
> >> make[1]: *** [Makefile:483: elf/tests] Error 2
> >> make: *** [Makefile:9: check] Error 2
> >>
> >> There's no error before that, or other message indicating which make
> >> target is failing.
> >>
> >> The full build log is here:
> >>
> >> <https://koji.fedoraproject.org/koji/taskinfo?taskID=78987342>
> >> <https://kojipkgs.fedoraproject.org//work/tasks/7342/78987342/build.log>
> >>
> >> The make error messages are not very helpful to me though.
> >>
> >
> > It also happened to me in a build directory whose path contains a
> > symbolic linked directory. Make was confused to include the generated
> > makefile twice, which could be reached with 2 different pathnames.
> > After removing the symbolic linked directory, the generated makefile
> > can be reached with a single pathname, the make error went away.
>
> This is a standard Koji build environment. The build directory is not a
> symbolic link:
>
> + readlink -f .
> /builddir/build/BUILD/glibc-2.34.9000-294-ga43c0b5483/build-x86_64-redhat-linux
>
> And we reach that via /builddir/build/BUILD.
>
> So I still don't know what's going on there.
>
In my case, the same makefile fragment was included twice. Can you try
https://sourceware.org/pipermail/libc-alpha/2021-November/132795.html
--
H.J.
next prev parent reply other threads:[~2021-11-17 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 13:14 H.J. Lu
2021-11-16 13:16 ` Adhemerval Zanella
2021-11-17 13:49 ` Florian Weimer
2021-11-17 13:56 ` H.J. Lu
2021-11-17 15:29 ` Florian Weimer
2021-11-17 15:39 ` H.J. Lu [this message]
2021-11-17 15:52 ` Florian Weimer
2021-11-17 16:02 ` H.J. Lu
2021-11-17 16:41 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOpYhDxSfOP0tAq7eb1wJ-Vy0RZy5iP6ZrSEEPDWsq8adw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).