From: "H.J. Lu" <hjl.tools@gmail.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: GNU C Library <libc-alpha@sourceware.org>, commit-hurd@gnu.org
Subject: Re: [PATCH] x86: Fix tst-ifunc-isa-* build when gcc ifunc support is not enabled
Date: Tue, 23 Mar 2021 16:09:18 -0700 [thread overview]
Message-ID: <CAMe9rOphm-Me7wBi5nNdEGG2OEhM+bd-+ZRoq9dQ=7o_DWYjXg@mail.gmail.com> (raw)
In-Reply-To: <20210323224853.322700-1-samuel.thibault@ens-lyon.org>
On Tue, Mar 23, 2021 at 3:49 PM Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
>
> ---
> sysdeps/x86/tst-ifunc-isa-1.c | 17 +++++++++++++++++
> sysdeps/x86/tst-ifunc-isa-2.c | 17 +++++++++++++++++
> 2 files changed, 34 insertions(+)
>
> diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c
> index 37d599210c..7a58591c79 100644
> --- a/sysdeps/x86/tst-ifunc-isa-1.c
> +++ b/sysdeps/x86/tst-ifunc-isa-1.c
> @@ -16,6 +16,10 @@
> License along with the GNU C Library; if not, see
> <https://www.gnu.org/licenses/>. */
>
> +#include <config.h>
> +
> +#ifdef HAVE_GCC_IFUNC
> +
> #include <stdlib.h>
> #include "tst-ifunc-isa.h"
>
> @@ -27,4 +31,17 @@ do_test (void)
> return value == expected ? EXIT_SUCCESS : EXIT_FAILURE;
> }
>
> +#else /* !HAVE_GCC_IFUNC */
> +
> +#include <support/check.h>
> +
> +static int
> +do_test (void)
> +{
> + FAIL_UNSUPPORTED ("GCC does not support the ifunc attribute");
> + return 1; /* Not reachable. */
> +}
> +
> +#endif /* !HAVE_GCC_IFUNC */
> +
> #include <support/test-driver.c>
Can you add LIBC_CONFIG_VAR with have-gcc-ifunc to skip
these tests?
--
H.J.
next prev parent reply other threads:[~2021-03-23 23:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 22:48 Samuel Thibault
2021-03-23 23:09 ` H.J. Lu [this message]
2021-03-24 0:17 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOphm-Me7wBi5nNdEGG2OEhM+bd-+ZRoq9dQ=7o_DWYjXg@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=commit-hurd@gnu.org \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).