From: "H.J. Lu" <hjl.tools@gmail.com>
To: GNU C Library <libc-alpha@sourceware.org>
Cc: Florian Weimer <fweimer@redhat.com>
Subject: PING^2 [PATCH] Run $(objpfx)iconvconfig as an installed program
Date: Thu, 6 May 2021 08:07:21 -0700 [thread overview]
Message-ID: <CAMe9rOpq2nDY4ciTWNZoyth-asrvsFp=EdJht2yMMS4KLs=0pg@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOriPPJJ=M=OaJdqsykXz3DDsR3zQ0y_O=_hk0AtutXdLA@mail.gmail.com>
On Mon, Apr 19, 2021 at 5:55 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Fri, Feb 26, 2021 at 1:15 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > When glibc is configured with --enable-hardcoded-path-in-tests,
> > "make xcheck" failed with
> >
> > ...
> > env GCONV_PATH=/export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/iconvdata LOCPATH=/export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/localedata LC_ALL=C /export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/iconv/iconvconfig --output=$tmp --nostdlib /usr/lib64/gconv;
> > ...
> > /export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/iconv/iconvconfig: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /export/build/gnu/tools-build/glibc-cet-gitlab/build-x86_64-linux/iconv/iconvconfig)
> > ...
> > FAIL: iconv/test-iconvconfig
> >
> > Since $(objpfx)iconvconfig is an installed program, run it as one.
> > ---
> > iconv/Makefile | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/iconv/Makefile b/iconv/Makefile
> > index 659857dd8c..4af3eea0d8 100644
> > --- a/iconv/Makefile
> > +++ b/iconv/Makefile
> > @@ -95,11 +95,13 @@ $(inst_bindir)/iconv: $(objpfx)iconv_prog $(+force)
> > $(objpfx)iconv_prog: $(iconv_prog-modules:%=$(objpfx)%.o)
> > $(objpfx)iconvconfig: $(iconvconfig-modules:%=$(objpfx)%.o)
> >
> > -$(objpfx)test-iconvconfig.out: /dev/null $(objpfx)iconvconfig
> > +$(objpfx)test-iconvconfig.out: $(objpfx)iconvconfig
> > (set -e; \
> > tmp=$(objpfx)gconv-modules.cache.$$$$; \
> > rm -f $$tmp; \
> > - $(make-test-out) --output=$$tmp --nostdlib $(inst_gconvdir); \
> > + $(built-program-cmd-before-env) \
> > + $(run-program-env) $(built-program-cmd-after-env) $< \
> > + --output=$$tmp --nostdlib $(inst_gconvdir); \
> > cmp $$tmp $(inst_gconvdir)/gconv-modules.cache; \
> > rm -f $$tmp) > $@; \
> > $(evaluate-test)
> > --
> > 2.29.2
> >
>
> PING.
>
Are there any comments on this? If not, I will check it in tomorrow.
--
H.J.
next prev parent reply other threads:[~2021-05-06 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 21:15 H.J. Lu
2021-04-19 12:55 ` PING^1 " H.J. Lu
2021-05-06 15:07 ` H.J. Lu [this message]
2021-05-06 15:23 ` Florian Weimer
2021-05-06 18:04 ` [PATCH v2] Run $(objpfx)iconvconfig with $(run-program-prefix) [BZ #27477] H.J. Lu
2021-05-07 10:21 ` Florian Weimer
2021-05-07 11:39 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOpq2nDY4ciTWNZoyth-asrvsFp=EdJht2yMMS4KLs=0pg@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).