public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] Run $(objpfx)iconvconfig with $(run-program-prefix) [BZ #27477]
Date: Fri, 7 May 2021 04:39:50 -0700	[thread overview]
Message-ID: <CAMe9rOpJbM6k=1W=Sp4LED94e42cUE+fqx_Ue2mLqE4RpPQEfw@mail.gmail.com> (raw)
In-Reply-To: <878s4qetes.fsf@oldenburg.str.redhat.com>

On Fri, May 7, 2021 at 3:21 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> >> Should tests use $(test-wrapper-env) instead of $(run-program-env)
> >
> > I think we should use
> >
> > $(run-program-prefix) $(objpfx)iconvconfig
>
> You are more familiar with the makefiles than I am.  I do not have any
> objection to the proposed patch.
>
> Thanks,
> Florian
>

I checked it in.

-- 
H.J.

      reply	other threads:[~2021-05-07 11:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 21:15 [PATCH] Run $(objpfx)iconvconfig as an installed program H.J. Lu
2021-04-19 12:55 ` PING^1 " H.J. Lu
2021-05-06 15:07   ` PING^2 " H.J. Lu
2021-05-06 15:23 ` Florian Weimer
2021-05-06 18:04   ` [PATCH v2] Run $(objpfx)iconvconfig with $(run-program-prefix) [BZ #27477] H.J. Lu
2021-05-07 10:21     ` Florian Weimer
2021-05-07 11:39       ` H.J. Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMe9rOpJbM6k=1W=Sp4LED94e42cUE+fqx_Ue2mLqE4RpPQEfw@mail.gmail.com' \
    --to=hjl.tools@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).