Re: [PATCH] Remove htonl.S for i386/x86_64

["H.J. Lu" <hjl.tools@gmail.com>]

On Thu, Oct 20, 2022 at 4:03 PM Cristian Rodríguez via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Generic implementation on top of __bswap_32 always expands
> inline to either bswap or movbe depending on -march=*.
>
> Signed-off-by: Cristian Rodríguez <crrodriguez@opensuse.org>
> ---
>  sysdeps/i386/htonl.S   | 34 ----------------------------------
>  sysdeps/x86_64/htonl.S | 34 ----------------------------------
>  2 files changed, 68 deletions(-)
>  delete mode 100644 sysdeps/i386/htonl.S
>  delete mode 100644 sysdeps/x86_64/htonl.S
>
> diff --git a/sysdeps/i386/htonl.S b/sysdeps/i386/htonl.S
> deleted file mode 100644
> index c925440fe4..0000000000
> --- a/sysdeps/i386/htonl.S
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -/* Change byte order in word.  For Intel 80x86, x >= 4.
> -   Copyright (C) 1997-2022 Free Software Foundation, Inc.
> -   This file is part of the GNU C Library.
> -
> -   The GNU C Library is free software; you can redistribute it and/or
> -   modify it under the terms of the GNU Lesser General Public
> -   License as published by the Free Software Foundation; either
> -   version 2.1 of the License, or (at your option) any later version.
> -
> -   The GNU C Library is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Lesser General Public License for more details.
> -
> -   You should have received a copy of the GNU Lesser General Public
> -   License along with the GNU C Library; if not, see
> -   <https://www.gnu.org/licenses/>.  */
> -
> -#include <sysdep.h>
> -#include "asm-syntax.h"
> -
> -/*
> -   INPUT PARAMETERS:
> -   word                (sp + 4)
> -*/
> -
> -       .text
> -ENTRY (htonl)
> -       movl    4(%esp), %eax
> -       bswap   %eax
> -       ret
> -END (htonl)
> -
> -weak_alias (htonl, ntohl)
> diff --git a/sysdeps/x86_64/htonl.S b/sysdeps/x86_64/htonl.S
> deleted file mode 100644
> index 469da6340b..0000000000
> --- a/sysdeps/x86_64/htonl.S
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -/* Change byte order in word.  For AMD x86-64.
> -   Copyright (C) 1997-2022 Free Software Foundation, Inc.
> -   This file is part of the GNU C Library.
> -
> -   The GNU C Library is free software; you can redistribute it and/or
> -   modify it under the terms of the GNU Lesser General Public
> -   License as published by the Free Software Foundation; either
> -   version 2.1 of the License, or (at your option) any later version.
> -
> -   The GNU C Library is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Lesser General Public License for more details.
> -
> -   You should have received a copy of the GNU Lesser General Public
> -   License along with the GNU C Library; if not, see
> -   <https://www.gnu.org/licenses/>.  */
> -
> -#include <sysdep.h>
> -#include "asm-syntax.h"
> -
> -/*
> -   INPUT PARAMETERS:
> -   word                %rdi
> -*/
> -
> -       .text
> -ENTRY (htonl)
> -       movl    %edi, %eax
> -       bswap   %eax
> -       ret
> -END (htonl)
> -
> -weak_alias (htonl, ntohl)
> --
> 2.38.0
>

LGTM.

Thanks.

-- 
H.J.