* [PATCH] Remove htonl.S for i386/x86_64
@ 2022-10-20 23:02 Cristian Rodríguez
2022-10-20 23:06 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: Cristian Rodríguez @ 2022-10-20 23:02 UTC (permalink / raw)
To: libc-alpha; +Cc: Cristian Rodríguez
Generic implementation on top of __bswap_32 always expands
inline to either bswap or movbe depending on -march=*.
Signed-off-by: Cristian Rodríguez <crrodriguez@opensuse.org>
---
sysdeps/i386/htonl.S | 34 ----------------------------------
sysdeps/x86_64/htonl.S | 34 ----------------------------------
2 files changed, 68 deletions(-)
delete mode 100644 sysdeps/i386/htonl.S
delete mode 100644 sysdeps/x86_64/htonl.S
diff --git a/sysdeps/i386/htonl.S b/sysdeps/i386/htonl.S
deleted file mode 100644
index c925440fe4..0000000000
--- a/sysdeps/i386/htonl.S
+++ /dev/null
@@ -1,34 +0,0 @@
-/* Change byte order in word. For Intel 80x86, x >= 4.
- Copyright (C) 1997-2022 Free Software Foundation, Inc.
- This file is part of the GNU C Library.
-
- The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- The GNU C Library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library; if not, see
- <https://www.gnu.org/licenses/>. */
-
-#include <sysdep.h>
-#include "asm-syntax.h"
-
-/*
- INPUT PARAMETERS:
- word (sp + 4)
-*/
-
- .text
-ENTRY (htonl)
- movl 4(%esp), %eax
- bswap %eax
- ret
-END (htonl)
-
-weak_alias (htonl, ntohl)
diff --git a/sysdeps/x86_64/htonl.S b/sysdeps/x86_64/htonl.S
deleted file mode 100644
index 469da6340b..0000000000
--- a/sysdeps/x86_64/htonl.S
+++ /dev/null
@@ -1,34 +0,0 @@
-/* Change byte order in word. For AMD x86-64.
- Copyright (C) 1997-2022 Free Software Foundation, Inc.
- This file is part of the GNU C Library.
-
- The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- The GNU C Library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library; if not, see
- <https://www.gnu.org/licenses/>. */
-
-#include <sysdep.h>
-#include "asm-syntax.h"
-
-/*
- INPUT PARAMETERS:
- word %rdi
-*/
-
- .text
-ENTRY (htonl)
- movl %edi, %eax
- bswap %eax
- ret
-END (htonl)
-
-weak_alias (htonl, ntohl)
--
2.38.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove htonl.S for i386/x86_64
2022-10-20 23:02 [PATCH] Remove htonl.S for i386/x86_64 Cristian Rodríguez
@ 2022-10-20 23:06 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2022-10-20 23:06 UTC (permalink / raw)
To: Cristian Rodríguez; +Cc: libc-alpha
On Thu, Oct 20, 2022 at 4:03 PM Cristian Rodríguez via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Generic implementation on top of __bswap_32 always expands
> inline to either bswap or movbe depending on -march=*.
>
> Signed-off-by: Cristian Rodríguez <crrodriguez@opensuse.org>
> ---
> sysdeps/i386/htonl.S | 34 ----------------------------------
> sysdeps/x86_64/htonl.S | 34 ----------------------------------
> 2 files changed, 68 deletions(-)
> delete mode 100644 sysdeps/i386/htonl.S
> delete mode 100644 sysdeps/x86_64/htonl.S
>
> diff --git a/sysdeps/i386/htonl.S b/sysdeps/i386/htonl.S
> deleted file mode 100644
> index c925440fe4..0000000000
> --- a/sysdeps/i386/htonl.S
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -/* Change byte order in word. For Intel 80x86, x >= 4.
> - Copyright (C) 1997-2022 Free Software Foundation, Inc.
> - This file is part of the GNU C Library.
> -
> - The GNU C Library is free software; you can redistribute it and/or
> - modify it under the terms of the GNU Lesser General Public
> - License as published by the Free Software Foundation; either
> - version 2.1 of the License, or (at your option) any later version.
> -
> - The GNU C Library is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> - Lesser General Public License for more details.
> -
> - You should have received a copy of the GNU Lesser General Public
> - License along with the GNU C Library; if not, see
> - <https://www.gnu.org/licenses/>. */
> -
> -#include <sysdep.h>
> -#include "asm-syntax.h"
> -
> -/*
> - INPUT PARAMETERS:
> - word (sp + 4)
> -*/
> -
> - .text
> -ENTRY (htonl)
> - movl 4(%esp), %eax
> - bswap %eax
> - ret
> -END (htonl)
> -
> -weak_alias (htonl, ntohl)
> diff --git a/sysdeps/x86_64/htonl.S b/sysdeps/x86_64/htonl.S
> deleted file mode 100644
> index 469da6340b..0000000000
> --- a/sysdeps/x86_64/htonl.S
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -/* Change byte order in word. For AMD x86-64.
> - Copyright (C) 1997-2022 Free Software Foundation, Inc.
> - This file is part of the GNU C Library.
> -
> - The GNU C Library is free software; you can redistribute it and/or
> - modify it under the terms of the GNU Lesser General Public
> - License as published by the Free Software Foundation; either
> - version 2.1 of the License, or (at your option) any later version.
> -
> - The GNU C Library is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> - Lesser General Public License for more details.
> -
> - You should have received a copy of the GNU Lesser General Public
> - License along with the GNU C Library; if not, see
> - <https://www.gnu.org/licenses/>. */
> -
> -#include <sysdep.h>
> -#include "asm-syntax.h"
> -
> -/*
> - INPUT PARAMETERS:
> - word %rdi
> -*/
> -
> - .text
> -ENTRY (htonl)
> - movl %edi, %eax
> - bswap %eax
> - ret
> -END (htonl)
> -
> -weak_alias (htonl, ntohl)
> --
> 2.38.0
>
LGTM.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-20 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-20 23:02 [PATCH] Remove htonl.S for i386/x86_64 Cristian Rodríguez
2022-10-20 23:06 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).