From: "H.J. Lu" <hjl.tools@gmail.com>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
"Carlos O'Donell" <carlos@systemhalted.org>
Subject: Re: [PATCH v1] x86: Fix `#define STRCPY` guard in strcpy-sse2.S
Date: Mon, 8 Aug 2022 07:21:57 -0700 [thread overview]
Message-ID: <CAMe9rOpxFQJ=QKh0-btUw+uWNeNvbMXf0P+wYXt_JwripdNOLQ@mail.gmail.com> (raw)
In-Reply-To: <20220808032622.3804534-1-goldstein.w.n@gmail.com>
On Sun, Aug 7, 2022 at 8:26 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> `#ifndef STPCPY` is incorrect for checking if `STRCPY` is already
> defined. It doesn't end up mattering as the whole check is
> guarded by `#if IS_IN (libc)` but is incorrect none the less.
> ---
> sysdeps/x86_64/multiarch/strcpy-sse2.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/strcpy-sse2.S b/sysdeps/x86_64/multiarch/strcpy-sse2.S
> index e29b411314..d6b9bae5f8 100644
> --- a/sysdeps/x86_64/multiarch/strcpy-sse2.S
> +++ b/sysdeps/x86_64/multiarch/strcpy-sse2.S
> @@ -22,7 +22,7 @@
>
> # include <sysdep.h>
>
> -# ifndef STPCPY
> +# ifndef STRCPY
> # define STRCPY __strcpy_sse2
> # endif
>
> --
> 2.34.1
>
LGTM.
Thanks.
--
H.J.
prev parent reply other threads:[~2022-08-08 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 3:26 Noah Goldstein
2022-08-08 3:26 ` [PATCH v1] elf: Replace `strcpy` call with `memcpy` [BZ #29454] Noah Goldstein
2022-08-08 10:19 ` Yann Droneaud
2022-08-08 14:23 ` H.J. Lu
2022-08-10 3:29 ` Noah Goldstein
2022-08-08 14:21 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOpxFQJ=QKh0-btUw+uWNeNvbMXf0P+wYXt_JwripdNOLQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=carlos@systemhalted.org \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).