From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/3] elf: Initialize GLRO (dl_minsigstacksize) after static dlopen
Date: Thu, 20 May 2021 07:40:32 -0700 [thread overview]
Message-ID: <CAMe9rOq-wnf6ZP2ZzmQH=JOsc9A5-uc5H-And85NMB-PHzNX=w@mail.gmail.com> (raw)
In-Reply-To: <8754fc98101550a1354a5dff2447b870a7c04291.1621511874.git.fweimer@redhat.com>
On Thu, May 20, 2021 at 6:08 AM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> This is another field of _rtld_global_ro that benefits from
> initialization in __rtld_static_init.
> ---
> elf/rtld_static_init.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/elf/rtld_static_init.c b/elf/rtld_static_init.c
> index bded6bd2d4..9c9e069b4d 100644
> --- a/elf/rtld_static_init.c
> +++ b/elf/rtld_static_init.c
> @@ -49,6 +49,8 @@ __rtld_static_init (struct link_map *map)
> dl->_dl_hwcap = _dl_hwcap;
> extern __typeof (dl->_dl_hwcap2) _dl_hwcap2 attribute_hidden;
> dl->_dl_hwcap2 = _dl_hwcap2;
> + extern __typeof (dl->_dl_hwcap2) _dl_minsigstacksize attribute_hidden;
> + dl->_dl_minsigstacksize = _dl_minsigstacksize;
> extern __typeof (dl->_dl_pagesize) _dl_pagesize attribute_hidden;
> dl->_dl_pagesize = _dl_pagesize;
> extern __typeof (dl->_dl_tls_static_align) _dl_tls_static_align
> --
> 2.31.1
>
>
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Thanks.
--
H.J.
next prev parent reply other threads:[~2021-05-20 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 12:11 [PATCH 0/3] Convenience function for allocating (alternate signal) stacks Florian Weimer
2021-05-20 12:13 ` [PATCH 1/3] elf: Initialize GLRO (dl_minsigstacksize) after static dlopen Florian Weimer
2021-05-20 14:40 ` H.J. Lu [this message]
2021-05-20 12:13 ` [PATCH 2/3] Hurd: Define ARCH_MIN_GUARD_SIZE in internal <pthread.h> Florian Weimer
2021-05-20 14:41 ` H.J. Lu
2021-05-20 12:13 ` [PATCH 3/3] Misc: Add <sys/cstack.h> and the cstack_* family of functions Florian Weimer
2021-05-20 12:21 ` Florian Weimer
2021-05-20 12:50 ` Andreas Schwab
2021-05-20 13:14 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOq-wnf6ZP2ZzmQH=JOsc9A5-uc5H-And85NMB-PHzNX=w@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).