* [PATCH] i386: Replace movzx with movzbl
@ 2022-08-04 6:04 Fangrui Song
2022-08-04 8:13 ` Noah Goldstein
2022-08-04 21:27 ` H.J. Lu
0 siblings, 2 replies; 3+ messages in thread
From: Fangrui Song @ 2022-08-04 6:04 UTC (permalink / raw)
To: libc-alpha, H.J. Lu
Similar to 6720d36b6623c5e48c070d86acf61198b33e144e for x86-64.
Clang cannot assemble movzx in the AT&T dialect mode. Change movzx to
movzbl, which follows the AT&T dialect and is used elsewhere in the
file.
---
sysdeps/i386/i686/multiarch/strcmp-ssse3.S | 36 +++++++++++-----------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
index ac5096f68d..3435691f23 100644
--- a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
+++ b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
@@ -2141,8 +2141,8 @@ L(less16bytes):
jbe L(eq)
#endif
- movzx 7(%eax), %ecx
- movzx 7(%edx), %eax
+ movzbl 7(%eax), %ecx
+ movzbl 7(%edx), %eax
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
# ifdef PIC
movl _nl_C_LC_CTYPE_tolower@GOTOFF+128*4(%ebx,%ecx,4), %ecx
@@ -2161,8 +2161,8 @@ L(Byte0):
cmp $0, REM
jbe L(eq)
#endif
- movzx (%eax), %ecx
- movzx (%edx), %eax
+ movzbl (%eax), %ecx
+ movzbl (%edx), %eax
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
# ifdef PIC
@@ -2182,8 +2182,8 @@ L(Byte1):
cmp $1, REM
jbe L(eq)
#endif
- movzx 1(%eax), %ecx
- movzx 1(%edx), %eax
+ movzbl 1(%eax), %ecx
+ movzbl 1(%edx), %eax
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
# ifdef PIC
@@ -2203,8 +2203,8 @@ L(Byte2):
cmp $2, REM
jbe L(eq)
#endif
- movzx 2(%eax), %ecx
- movzx 2(%edx), %eax
+ movzbl 2(%eax), %ecx
+ movzbl 2(%edx), %eax
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
# ifdef PIC
@@ -2224,8 +2224,8 @@ L(Byte3):
cmp $3, REM
jbe L(eq)
#endif
- movzx 3(%eax), %ecx
- movzx 3(%edx), %eax
+ movzbl 3(%eax), %ecx
+ movzbl 3(%edx), %eax
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
# ifdef PIC
@@ -2245,8 +2245,8 @@ L(Byte4):
cmp $4, REM
jbe L(eq)
#endif
- movzx 4(%eax), %ecx
- movzx 4(%edx), %eax
+ movzbl 4(%eax), %ecx
+ movzbl 4(%edx), %eax
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
# ifdef PIC
@@ -2266,8 +2266,8 @@ L(Byte5):
cmp $5, REM
jbe L(eq)
#endif
- movzx 5(%eax), %ecx
- movzx 5(%edx), %eax
+ movzbl 5(%eax), %ecx
+ movzbl 5(%edx), %eax
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
# ifdef PIC
@@ -2287,8 +2287,8 @@ L(Byte6):
cmp $6, REM
jbe L(eq)
#endif
- movzx 6(%eax), %ecx
- movzx 6(%edx), %eax
+ movzbl 6(%eax), %ecx
+ movzbl 6(%edx), %eax
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
# ifdef PIC
@@ -2337,8 +2337,8 @@ L(2next_8_bytes):
cmp $7, REM
jbe L(eq)
#endif
- movzx 7(%eax), %ecx
- movzx 7(%edx), %eax
+ movzbl 7(%eax), %ecx
+ movzbl 7(%edx), %eax
#if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
# ifdef PIC
--
2.37.1.559.g78731f0fdb-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i386: Replace movzx with movzbl
2022-08-04 6:04 [PATCH] i386: Replace movzx with movzbl Fangrui Song
@ 2022-08-04 8:13 ` Noah Goldstein
2022-08-04 21:27 ` H.J. Lu
1 sibling, 0 replies; 3+ messages in thread
From: Noah Goldstein @ 2022-08-04 8:13 UTC (permalink / raw)
To: Fangrui Song; +Cc: GNU C Library, H.J. Lu
On Thu, Aug 4, 2022 at 2:04 PM Fangrui Song via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Similar to 6720d36b6623c5e48c070d86acf61198b33e144e for x86-64.
>
> Clang cannot assemble movzx in the AT&T dialect mode. Change movzx to
> movzbl, which follows the AT&T dialect and is used elsewhere in the
> file.
> ---
> sysdeps/i386/i686/multiarch/strcmp-ssse3.S | 36 +++++++++++-----------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
> index ac5096f68d..3435691f23 100644
> --- a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
> +++ b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
> @@ -2141,8 +2141,8 @@ L(less16bytes):
> jbe L(eq)
> #endif
>
> - movzx 7(%eax), %ecx
> - movzx 7(%edx), %eax
> + movzbl 7(%eax), %ecx
> + movzbl 7(%edx), %eax
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> movl _nl_C_LC_CTYPE_tolower@GOTOFF+128*4(%ebx,%ecx,4), %ecx
> @@ -2161,8 +2161,8 @@ L(Byte0):
> cmp $0, REM
> jbe L(eq)
> #endif
> - movzx (%eax), %ecx
> - movzx (%edx), %eax
> + movzbl (%eax), %ecx
> + movzbl (%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2182,8 +2182,8 @@ L(Byte1):
> cmp $1, REM
> jbe L(eq)
> #endif
> - movzx 1(%eax), %ecx
> - movzx 1(%edx), %eax
> + movzbl 1(%eax), %ecx
> + movzbl 1(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2203,8 +2203,8 @@ L(Byte2):
> cmp $2, REM
> jbe L(eq)
> #endif
> - movzx 2(%eax), %ecx
> - movzx 2(%edx), %eax
> + movzbl 2(%eax), %ecx
> + movzbl 2(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2224,8 +2224,8 @@ L(Byte3):
> cmp $3, REM
> jbe L(eq)
> #endif
> - movzx 3(%eax), %ecx
> - movzx 3(%edx), %eax
> + movzbl 3(%eax), %ecx
> + movzbl 3(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2245,8 +2245,8 @@ L(Byte4):
> cmp $4, REM
> jbe L(eq)
> #endif
> - movzx 4(%eax), %ecx
> - movzx 4(%edx), %eax
> + movzbl 4(%eax), %ecx
> + movzbl 4(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2266,8 +2266,8 @@ L(Byte5):
> cmp $5, REM
> jbe L(eq)
> #endif
> - movzx 5(%eax), %ecx
> - movzx 5(%edx), %eax
> + movzbl 5(%eax), %ecx
> + movzbl 5(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2287,8 +2287,8 @@ L(Byte6):
> cmp $6, REM
> jbe L(eq)
> #endif
> - movzx 6(%eax), %ecx
> - movzx 6(%edx), %eax
> + movzbl 6(%eax), %ecx
> + movzbl 6(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2337,8 +2337,8 @@ L(2next_8_bytes):
> cmp $7, REM
> jbe L(eq)
> #endif
> - movzx 7(%eax), %ecx
> - movzx 7(%edx), %eax
> + movzbl 7(%eax), %ecx
> + movzbl 7(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> --
> 2.37.1.559.g78731f0fdb-goog
>
LGTM.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i386: Replace movzx with movzbl
2022-08-04 6:04 [PATCH] i386: Replace movzx with movzbl Fangrui Song
2022-08-04 8:13 ` Noah Goldstein
@ 2022-08-04 21:27 ` H.J. Lu
1 sibling, 0 replies; 3+ messages in thread
From: H.J. Lu @ 2022-08-04 21:27 UTC (permalink / raw)
To: Fangrui Song; +Cc: GNU C Library
On Wed, Aug 3, 2022 at 11:04 PM Fangrui Song <maskray@google.com> wrote:
>
> Similar to 6720d36b6623c5e48c070d86acf61198b33e144e for x86-64.
>
> Clang cannot assemble movzx in the AT&T dialect mode. Change movzx to
> movzbl, which follows the AT&T dialect and is used elsewhere in the
> file.
> ---
> sysdeps/i386/i686/multiarch/strcmp-ssse3.S | 36 +++++++++++-----------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
> index ac5096f68d..3435691f23 100644
> --- a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
> +++ b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
> @@ -2141,8 +2141,8 @@ L(less16bytes):
> jbe L(eq)
> #endif
>
> - movzx 7(%eax), %ecx
> - movzx 7(%edx), %eax
> + movzbl 7(%eax), %ecx
> + movzbl 7(%edx), %eax
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> movl _nl_C_LC_CTYPE_tolower@GOTOFF+128*4(%ebx,%ecx,4), %ecx
> @@ -2161,8 +2161,8 @@ L(Byte0):
> cmp $0, REM
> jbe L(eq)
> #endif
> - movzx (%eax), %ecx
> - movzx (%edx), %eax
> + movzbl (%eax), %ecx
> + movzbl (%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2182,8 +2182,8 @@ L(Byte1):
> cmp $1, REM
> jbe L(eq)
> #endif
> - movzx 1(%eax), %ecx
> - movzx 1(%edx), %eax
> + movzbl 1(%eax), %ecx
> + movzbl 1(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2203,8 +2203,8 @@ L(Byte2):
> cmp $2, REM
> jbe L(eq)
> #endif
> - movzx 2(%eax), %ecx
> - movzx 2(%edx), %eax
> + movzbl 2(%eax), %ecx
> + movzbl 2(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2224,8 +2224,8 @@ L(Byte3):
> cmp $3, REM
> jbe L(eq)
> #endif
> - movzx 3(%eax), %ecx
> - movzx 3(%edx), %eax
> + movzbl 3(%eax), %ecx
> + movzbl 3(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2245,8 +2245,8 @@ L(Byte4):
> cmp $4, REM
> jbe L(eq)
> #endif
> - movzx 4(%eax), %ecx
> - movzx 4(%edx), %eax
> + movzbl 4(%eax), %ecx
> + movzbl 4(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2266,8 +2266,8 @@ L(Byte5):
> cmp $5, REM
> jbe L(eq)
> #endif
> - movzx 5(%eax), %ecx
> - movzx 5(%edx), %eax
> + movzbl 5(%eax), %ecx
> + movzbl 5(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2287,8 +2287,8 @@ L(Byte6):
> cmp $6, REM
> jbe L(eq)
> #endif
> - movzx 6(%eax), %ecx
> - movzx 6(%edx), %eax
> + movzbl 6(%eax), %ecx
> + movzbl 6(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> @@ -2337,8 +2337,8 @@ L(2next_8_bytes):
> cmp $7, REM
> jbe L(eq)
> #endif
> - movzx 7(%eax), %ecx
> - movzx 7(%edx), %eax
> + movzbl 7(%eax), %ecx
> + movzbl 7(%edx), %eax
>
> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
> # ifdef PIC
> --
> 2.37.1.559.g78731f0fdb-goog
>
LGTM.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-04 21:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-04 6:04 [PATCH] i386: Replace movzx with movzbl Fangrui Song
2022-08-04 8:13 ` Noah Goldstein
2022-08-04 21:27 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).