From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Linux: Remove exit system call from _exit
Date: Wed, 3 Aug 2022 09:58:56 -0700 [thread overview]
Message-ID: <CAMe9rOqtbL9Yj5nMzO05htwB8UhbkJuq8q0Zj4c+zbAXz+RwwA@mail.gmail.com> (raw)
In-Reply-To: <87o7x1b9y7.fsf@oldenburg.str.redhat.com>
On Wed, Aug 3, 2022 at 8:53 AM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> exit only terminates the current thread, not the whole process, so it
> is the wrong fallback system call in this context. All supported
> Linux versions implement the exit_group system call anyway.
>
> ---
> sysdeps/unix/sysv/linux/_exit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sysdeps/unix/sysv/linux/_exit.c b/sysdeps/unix/sysv/linux/_exit.c
> index 7ad3e0aae4..f916d97ae2 100644
> --- a/sysdeps/unix/sysv/linux/_exit.c
> +++ b/sysdeps/unix/sysv/linux/_exit.c
> @@ -28,7 +28,6 @@ _exit (int status)
> while (1)
> {
> INLINE_SYSCALL (exit_group, 1, status);
> - INLINE_SYSCALL (exit, 1, status);
>
> #ifdef ABORT_INSTRUCTION
> ABORT_INSTRUCTION;
>
LGTM.
Thanks.
--
H.J.
prev parent reply other threads:[~2022-08-03 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 15:53 Florian Weimer
2022-08-03 16:58 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOqtbL9Yj5nMzO05htwB8UhbkJuq8q0Zj4c+zbAXz+RwwA@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).