From: "H.J. Lu" <hjl.tools@gmail.com>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] x86: Use CHECK_FEATURE_PRESENT on PCONFIG
Date: Sat, 12 Feb 2022 07:51:08 -0800 [thread overview]
Message-ID: <CAMe9rOrE2JpXB=t1creRTdH4_egP_BZ_TheRRe=r3kW9wM7zCg@mail.gmail.com> (raw)
In-Reply-To: <20220126202824.1810825-1-hjl.tools@gmail.com>
On Wed, Jan 26, 2022 at 12:28 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> PCONFIG is a privileged instruction. Use CHECK_FEATURE_PRESENT, instead
> of CHECK_FEATURE_ACTIVE, on PCONFIG in tst-cpu-features-supports.c.
> ---
> sysdeps/x86/tst-cpu-features-supports.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86/tst-cpu-features-supports.c b/sysdeps/x86/tst-cpu-features-supports.c
> index 46b2c7bf83..997b641449 100644
> --- a/sysdeps/x86/tst-cpu-features-supports.c
> +++ b/sysdeps/x86/tst-cpu-features-supports.c
> @@ -143,7 +143,7 @@ do_test (int argc, char **argv)
> fails += CHECK_FEATURE_ACTIVE (movdiri, MOVDIRI);
> fails += CHECK_FEATURE_ACTIVE (movdir64b, MOVDIR64B);
> fails += CHECK_FEATURE_ACTIVE (osxsave, OSXSAVE);
> - fails += CHECK_FEATURE_ACTIVE (pconfig, PCONFIG);
> + fails += CHECK_FEATURE_PRESENT (pconfig, PCONFIG);
> fails += CHECK_FEATURE_ACTIVE (pku, PKU);
> #endif
> fails += CHECK_FEATURE_ACTIVE (popcnt, POPCNT);
> --
> 2.34.1
>
I will check in this next Monday to fix the test on Intel Alder Lake.
--
H.J.
prev parent reply other threads:[~2022-02-12 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 20:28 H.J. Lu
2022-02-12 15:51 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrE2JpXB=t1creRTdH4_egP_BZ_TheRRe=r3kW9wM7zCg@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).