From: "H.J. Lu" <hjl.tools@gmail.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Fangrui Song <maskray@google.com>
Subject: Re: [PATCH] i386: Use cmpl instead of cmp
Date: Thu, 4 Aug 2022 14:25:08 -0700 [thread overview]
Message-ID: <CAMe9rOrq8O9f_W+K6+LR+P48U5ZMXydawUGSebOhbvJDzvWFmw@mail.gmail.com> (raw)
In-Reply-To: <20220804210037.2613528-1-adhemerval.zanella@linaro.org>
On Thu, Aug 4, 2022 at 2:00 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> Clang cannot assemble cmp in the AT&T dialect mode.
> ---
> sysdeps/i386/i686/multiarch/wcscpy-ssse3.S | 8 ++++----
> sysdeps/i386/i686/multiarch/wcslen-sse2.S | 16 ++++++++--------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S b/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S
> index 601e0f0138..fa6598c54d 100644
> --- a/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S
> +++ b/sysdeps/i386/i686/multiarch/wcscpy-ssse3.S
> @@ -41,13 +41,13 @@ ENTRY (__wcscpy_ssse3)
> mov STR1(%esp), %edx
> mov STR2(%esp), %ecx
>
> - cmp $0, (%ecx)
> + cmpl $0, (%ecx)
> jz L(ExitTail4)
> - cmp $0, 4(%ecx)
> + cmpl $0, 4(%ecx)
> jz L(ExitTail8)
> - cmp $0, 8(%ecx)
> + cmpl $0, 8(%ecx)
> jz L(ExitTail12)
> - cmp $0, 12(%ecx)
> + cmpl $0, 12(%ecx)
> jz L(ExitTail16)
>
> PUSH (%edi)
> diff --git a/sysdeps/i386/i686/multiarch/wcslen-sse2.S b/sysdeps/i386/i686/multiarch/wcslen-sse2.S
> index 5337286d41..d49a7ce355 100644
> --- a/sysdeps/i386/i686/multiarch/wcslen-sse2.S
> +++ b/sysdeps/i386/i686/multiarch/wcslen-sse2.S
> @@ -24,21 +24,21 @@
> ENTRY (__wcslen_sse2)
> mov STR(%esp), %edx
>
> - cmp $0, (%edx)
> + cmpl $0, (%edx)
> jz L(exit_tail0)
> - cmp $0, 4(%edx)
> + cmpl $0, 4(%edx)
> jz L(exit_tail1)
> - cmp $0, 8(%edx)
> + cmpl $0, 8(%edx)
> jz L(exit_tail2)
> - cmp $0, 12(%edx)
> + cmpl $0, 12(%edx)
> jz L(exit_tail3)
> - cmp $0, 16(%edx)
> + cmpl $0, 16(%edx)
> jz L(exit_tail4)
> - cmp $0, 20(%edx)
> + cmpl $0, 20(%edx)
> jz L(exit_tail5)
> - cmp $0, 24(%edx)
> + cmpl $0, 24(%edx)
> jz L(exit_tail6)
> - cmp $0, 28(%edx)
> + cmpl $0, 28(%edx)
> jz L(exit_tail7)
>
> pxor %xmm0, %xmm0
> --
> 2.34.1
LGTM.
Thanks.
--
H.J.
prev parent reply other threads:[~2022-08-04 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 21:00 Adhemerval Zanella
2022-08-04 21:09 ` Fangrui Song
2022-08-04 21:25 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOrq8O9f_W+K6+LR+P48U5ZMXydawUGSebOhbvJDzvWFmw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).