* [PATCH v1] x86: Fix TEST_NAME to make it a string
@ 2022-02-18 22:59 Noah Goldstein
2022-02-18 23:00 ` [PATCH v2] x86: Fix TEST_NAME to make it a string in tst-strncmp-rtm.c Noah Goldstein
0 siblings, 1 reply; 3+ messages in thread
From: Noah Goldstein @ 2022-02-18 22:59 UTC (permalink / raw)
To: libc-alpha
Previously TEST_NAME was passing a function pointer. This didn't fail
because of the -Wno-error flag (to allow for overflow sizes passed
to strncmp/wcsncmp)
---
sysdeps/x86/tst-strncmp-rtm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sysdeps/x86/tst-strncmp-rtm.c b/sysdeps/x86/tst-strncmp-rtm.c
index b50c11e8d4..300bc8c281 100644
--- a/sysdeps/x86/tst-strncmp-rtm.c
+++ b/sysdeps/x86/tst-strncmp-rtm.c
@@ -23,12 +23,12 @@
# define CHAR wchar_t
# define MEMSET wmemset
# define STRNCMP wcsncmp
-# define TEST_NAME wcsncmp
+# define TEST_NAME "wcsncmp"
#else /* !WIDE */
# define CHAR char
# define MEMSET memset
# define STRNCMP strncmp
-# define TEST_NAME strncmp
+# define TEST_NAME "strncmp"
#endif /* !WIDE */
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] x86: Fix TEST_NAME to make it a string in tst-strncmp-rtm.c
2022-02-18 22:59 [PATCH v1] x86: Fix TEST_NAME to make it a string Noah Goldstein
@ 2022-02-18 23:00 ` Noah Goldstein
2022-02-18 23:11 ` H.J. Lu
0 siblings, 1 reply; 3+ messages in thread
From: Noah Goldstein @ 2022-02-18 23:00 UTC (permalink / raw)
To: libc-alpha
Previously TEST_NAME was passing a function pointer. This didn't fail
because of the -Wno-error flag (to allow for overflow sizes passed
to strncmp/wcsncmp)
---
sysdeps/x86/tst-strncmp-rtm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sysdeps/x86/tst-strncmp-rtm.c b/sysdeps/x86/tst-strncmp-rtm.c
index b50c11e8d4..300bc8c281 100644
--- a/sysdeps/x86/tst-strncmp-rtm.c
+++ b/sysdeps/x86/tst-strncmp-rtm.c
@@ -23,12 +23,12 @@
# define CHAR wchar_t
# define MEMSET wmemset
# define STRNCMP wcsncmp
-# define TEST_NAME wcsncmp
+# define TEST_NAME "wcsncmp"
#else /* !WIDE */
# define CHAR char
# define MEMSET memset
# define STRNCMP strncmp
-# define TEST_NAME strncmp
+# define TEST_NAME "strncmp"
#endif /* !WIDE */
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] x86: Fix TEST_NAME to make it a string in tst-strncmp-rtm.c
2022-02-18 23:00 ` [PATCH v2] x86: Fix TEST_NAME to make it a string in tst-strncmp-rtm.c Noah Goldstein
@ 2022-02-18 23:11 ` H.J. Lu
0 siblings, 0 replies; 3+ messages in thread
From: H.J. Lu @ 2022-02-18 23:11 UTC (permalink / raw)
To: Noah Goldstein; +Cc: libc-alpha, carlos
On Fri, Feb 18, 2022 at 3:00 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> Previously TEST_NAME was passing a function pointer. This didn't fail
> because of the -Wno-error flag (to allow for overflow sizes passed
> to strncmp/wcsncmp)
> ---
> sysdeps/x86/tst-strncmp-rtm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sysdeps/x86/tst-strncmp-rtm.c b/sysdeps/x86/tst-strncmp-rtm.c
> index b50c11e8d4..300bc8c281 100644
> --- a/sysdeps/x86/tst-strncmp-rtm.c
> +++ b/sysdeps/x86/tst-strncmp-rtm.c
> @@ -23,12 +23,12 @@
> # define CHAR wchar_t
> # define MEMSET wmemset
> # define STRNCMP wcsncmp
> -# define TEST_NAME wcsncmp
> +# define TEST_NAME "wcsncmp"
> #else /* !WIDE */
> # define CHAR char
> # define MEMSET memset
> # define STRNCMP strncmp
> -# define TEST_NAME strncmp
> +# define TEST_NAME "strncmp"
> #endif /* !WIDE */
>
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-18 23:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-18 22:59 [PATCH v1] x86: Fix TEST_NAME to make it a string Noah Goldstein
2022-02-18 23:00 ` [PATCH v2] x86: Fix TEST_NAME to make it a string in tst-strncmp-rtm.c Noah Goldstein
2022-02-18 23:11 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).