From: Jesse Hathaway <jesse@mbuki-mvuki.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] getlogin_r: return early when linux sentinel value is set
Date: Wed, 21 Mar 2018 21:28:00 -0000 [thread overview]
Message-ID: <CANSNSoV4Kf_HffDhJboyPrV15P0tL8aB+21ccBz1Anf0q1nb1w@mail.gmail.com> (raw)
In-Reply-To: <877eq6ppkw.fsf@linux-m68k.org>
On Tue, Mar 20, 2018 at 1:30 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Depends on whether you want the linux __getlogin_r to fall back to the
> generic __getlogin_r.
Thanks, updated patch below:
From 04a50b5ee857aa33e1527d70f0676b6daf5a036c Mon Sep 17 00:00:00 2001
From: Jesse Hathaway <jesse@mbuki-mvuki.org>
Date: Fri, 16 Mar 2018 10:46:50 -0500
Subject: [PATCH] getlogin_r: return early when linux sentinel value is set
When there is no login uid Linux sets /proc/self/loginid to the sentinel
value of, (uid_t) - 1. If this is set we can return early and avoid
needlessly looking up the sentinel value in any configured nss
databases.
diff --git a/ChangeLog b/ChangeLog
index 3399e567b8..1ceff1c094 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-03-20 Jesse Hathaway <jesse@mbuki-mvuki.org> (tiny change)
+
+ * sysdeps/unix/sysv/linux/getlogin_r.c (__getlogin_r_loginuid): return early
+ when linux sentinel value is set.
+
2018-03-20 Samuel Thibault <samuel.thibault@ens-lyon.org>
* manual/errno.texi (EOWNERDEAD, ENOTRECOVERABLE): Remove errno
diff --git a/sysdeps/unix/sysv/linux/getlogin_r.c
b/sysdeps/unix/sysv/linux/getlogin_r.c
index 73ea14c8f9..1f90c1ca2d 100644
--- a/sysdeps/unix/sysv/linux/getlogin_r.c
+++ b/sysdeps/unix/sysv/linux/getlogin_r.c
@@ -55,6 +55,15 @@ __getlogin_r_loginuid (char *name, size_t namesize)
endp == uidbuf || *endp != '\0'))
return -1;
+ /* If there is no login uid, linux sets /proc/self/loginid to the sentinel
+ value of, (uid_t) - 1, so check if that value is set and return early to
+ avoid making unneeded nss lookups. */
+ if (uid == (uid_t) - 1)
+ {
+ __set_errno (ENXIO);
+ return ENXIO;
+ }
+
struct passwd pwd;
struct passwd *tpwd;
int result = 0;
next prev parent reply other threads:[~2018-03-21 21:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 16:18 Jesse Hathaway
2018-03-19 15:03 ` Jesse Hathaway
2018-03-20 8:00 ` Adhemerval Zanella
2018-03-20 9:05 ` Andreas Schwab
2018-03-20 17:52 ` Jesse Hathaway
2018-03-20 18:30 ` Andreas Schwab
2018-03-21 21:28 ` Jesse Hathaway [this message]
2018-03-22 6:14 ` Adhemerval Zanella
2018-03-22 13:49 ` Jesse Hathaway
2018-03-22 17:35 ` Andreas Schwab
2018-03-22 19:30 ` Jesse Hathaway
2018-03-26 14:22 ` Jesse Hathaway
2018-03-26 16:30 ` Adhemerval Zanella
2018-03-28 0:37 ` Adhemerval Zanella
2018-04-03 10:46 ` Florian Weimer
2018-04-03 11:41 ` Adhemerval Zanella
2018-04-03 11:45 ` Florian Weimer
2018-04-03 11:53 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANSNSoV4Kf_HffDhJboyPrV15P0tL8aB+21ccBz1Anf0q1nb1w@mail.gmail.com \
--to=jesse@mbuki-mvuki.org \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).