From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Jesse Hathaway <jesse@mbuki-mvuki.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>, libc-alpha@sourceware.org
Subject: Re: [PATCH] getlogin_r: return early when linux sentinel value is set
Date: Tue, 03 Apr 2018 11:45:00 -0000 [thread overview]
Message-ID: <a6ca81cc-1acb-b4b9-9f08-6742ebb9faf3@redhat.com> (raw)
In-Reply-To: <9d48f5d8-3465-2003-6ca4-f0deef2891cf@linaro.org>
On 04/03/2018 01:40 PM, Adhemerval Zanella wrote:
>
>
> On 03/04/2018 07:46, Florian Weimer wrote:
>> On 03/28/2018 02:37 AM, Adhemerval Zanella wrote:
>>> Pushed upstream.
>>>
>>> On 26/03/2018 13:30, Adhemerval Zanella wrote:
>>>> I will take care of it today, thanks for remind me.
>>>>
>>>> Sent from my iPhone
>>>>
>>>>> On 26 Mar 2018, at 11:22, Jesse Hathaway <jesse@mbuki-mvuki.org> wrote:
>>>>>
>>>>>> On Thu, Mar 22, 2018 at 2:30 PM, Jesse Hathaway <jesse@mbuki-mvuki.org> wrote:
>>>>>> fixed, attached
>>>>>
>>>>> Adhemerval Zanella would you be able to push this for me?
>>>>> <getlogin_r.c.patch>
>>
>> If this has user-visible impact, it should have a bug in Bugzilla, referenced from the ChangeLog entry.
> My understanding it is optimization to avoid access nss in
> case of invalid uid.
There's a Launchpad bug that suggests a very visible difference in behavior:
https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1760713
Thanks,
Florian
next prev parent reply other threads:[~2018-04-03 11:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 16:18 Jesse Hathaway
2018-03-19 15:03 ` Jesse Hathaway
2018-03-20 8:00 ` Adhemerval Zanella
2018-03-20 9:05 ` Andreas Schwab
2018-03-20 17:52 ` Jesse Hathaway
2018-03-20 18:30 ` Andreas Schwab
2018-03-21 21:28 ` Jesse Hathaway
2018-03-22 6:14 ` Adhemerval Zanella
2018-03-22 13:49 ` Jesse Hathaway
2018-03-22 17:35 ` Andreas Schwab
2018-03-22 19:30 ` Jesse Hathaway
2018-03-26 14:22 ` Jesse Hathaway
2018-03-26 16:30 ` Adhemerval Zanella
2018-03-28 0:37 ` Adhemerval Zanella
2018-04-03 10:46 ` Florian Weimer
2018-04-03 11:41 ` Adhemerval Zanella
2018-04-03 11:45 ` Florian Weimer [this message]
2018-04-03 11:53 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ca81cc-1acb-b4b9-9f08-6742ebb9faf3@redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=jesse@mbuki-mvuki.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).