public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Frederic Berat <fberat@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] localedata: Convert French language locales (fr_*) to UTF_8
Date: Wed, 17 Aug 2022 10:57:54 +0200	[thread overview]
Message-ID: <CAObJKZoAhv3OhN2eDWK9S0L=3jF=+zMSBP5RchkThT0XxxwRZg@mail.gmail.com> (raw)
In-Reply-To: <87zgg34869.fsf@oldenburg.str.redhat.com>

On Wed, Aug 17, 2022 at 9:54 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> ---
>  localedata/locales/fr_BE | 18 +++++++++---------
>  localedata/locales/fr_CA | 18 +++++++++---------
>  localedata/locales/fr_CH | 16 ++++++++--------
>  localedata/locales/fr_FR | 20 ++++++++++----------
>  localedata/locales/fr_LU | 22 +++++++++++-----------
>  5 files changed, 47 insertions(+), 47 deletions(-)
>
> diff --git a/localedata/locales/fr_BE b/localedata/locales/fr_BE
> index 39355fb89c..af222f76c2 100644
> --- a/localedata/locales/fr_BE
> +++ b/localedata/locales/fr_BE
> @@ -25,7 +25,7 @@ escape_char /
>  LC_IDENTIFICATION
>  title      "French locale for Belgium"
>  source     "RAP"
> -address    "Sankt J<U00F8>rgens Alle 8, DK-1615 K<U00F8>benhavn V, Danmark"
> +address    "Sankt Jørgens Alle 8, DK-1615 København V, Danmark"
>  contact    ""
>  email      "bug-glibc-locales@gnu.org"
>  tel        ""
> @@ -66,7 +66,7 @@ END LC_MESSAGES
>
>  LC_MONETARY
>  int_curr_symbol           "EUR "
> -currency_symbol           "<U20AC>"
> +currency_symbol           "€"
>  mon_decimal_point         ","
>  mon_thousands_sep         "."
>  mon_grouping              3;3
> @@ -97,24 +97,24 @@ day     "dimanche";/
>         "jeudi";/
>         "vendredi";/
>         "samedi"
> -abmon   "jan";"f<U00E9>v";/
> +abmon   "jan";"fév";/
>         "mar";"avr";/
>         "mai";"jun";/
> -       "jui";"ao<U00FB>";/
> +       "jui";"aoû";/
>         "sep";"oct";/
> -       "nov";"d<U00E9>c"
> +       "nov";"déc"
>  mon     "janvier";/
> -       "f<U00E9>vrier";/
> +       "février";/
>         "mars";/
>         "avril";/
>         "mai";/
>         "juin";/
>         "juillet";/
> -       "ao<U00FB>t";/
> +       "août";/
>         "septembre";/
>         "octobre";/
>         "novembre";/
> -       "d<U00E9>cembre"
> +       "décembre"
>  d_t_fmt  "%a %d %b %Y %T"
>  date_fmt "%a %d %b %Y %T %Z"
>  d_fmt   "%d//%m//%y"
> @@ -151,7 +151,7 @@ country_ab2 "BE"
>  country_ab3 "BEL"
>  country_num 056
>  country_car "B"
> -lang_name "fran<U00E7>ais"
> +lang_name "français"
>  lang_ab      "fr"
>  lang_term    "fra"
>  lang_lib  "fre"
> diff --git a/localedata/locales/fr_CA b/localedata/locales/fr_CA
> index 71c0d17ff6..4c3f05d98d 100644
> --- a/localedata/locales/fr_CA
> +++ b/localedata/locales/fr_CA
> @@ -25,7 +25,7 @@ escape_char /
>  LC_IDENTIFICATION
>  title      "French locale for Canada"
>  source     "RAP"
> -address    "Sankt J<U00F8>rgens Alle 8, DK-1615 K<U00F8>benhavn V, Danmark"
> +address    "Sankt Jørgens Alle 8, DK-1615 København V, Danmark"
>  contact    ""
>  email      "bug-glibc-locales@gnu.org"
>  tel        ""
> @@ -67,7 +67,7 @@ LC_MONETARY
>  int_curr_symbol           "CAD "
>  currency_symbol           "$"
>  mon_decimal_point         ","
> -mon_thousands_sep         "<U202F>"
> +mon_thousands_sep         " "

NNBSP, looks ok

>  mon_grouping              3;3
>  positive_sign             ""
>  negative_sign             "-"
> @@ -94,24 +94,24 @@ day     "dimanche";/
>         "jeudi";/
>         "vendredi";/
>         "samedi"
> -abmon   "jan";"f<U00E9>v";/
> +abmon   "jan";"fév";/
>         "mar";"avr";/
>         "mai";"jun";/
> -       "jui";"ao<U00FB>";/
> +       "jui";"aoû";/
>         "sep";"oct";/
> -       "nov";"d<U00E9>c"
> +       "nov";"déc"
>  mon     "janvier";/
> -       "f<U00E9>vrier";/
> +       "février";/
>         "mars";/
>         "avril";/
>         "mai";/
>         "juin";/
>         "juillet";/
> -       "ao<U00FB>t";/
> +       "août";/
>         "septembre";/
>         "octobre";/
>         "novembre";/
> -       "d<U00E9>cembre"
> +       "décembre"
>  d_t_fmt  "%a %d %b %Y %T"
>  date_fmt "%a %d %b %Y %T %Z"
>  d_fmt   "%Y-%m-%d"
> @@ -144,7 +144,7 @@ country_ab2 "CA"
>  country_ab3 "CAN"
>  country_num 124
>  country_car    "CDN"
> -lang_name "fran<U00E7>ais"
> +lang_name "français"
>  lang_ab      "fr"
>  lang_term    "fra"
>  lang_lib  "fre"
> diff --git a/localedata/locales/fr_CH b/localedata/locales/fr_CH
> index d9c67f9c65..690a04b763 100644
> --- a/localedata/locales/fr_CH
> +++ b/localedata/locales/fr_CH
> @@ -25,7 +25,7 @@ escape_char /
>  LC_IDENTIFICATION
>  title      "French locale for Switzerland"
>  source     "RAP"
> -address    "Sankt J<U00F8>rgens Alle 8, DK-1615 K<U00F8>benhavn V, Danmark"
> +address    "Sankt Jørgens Alle 8, DK-1615 København V, Danmark"
>  contact    ""
>  email      "bug-glibc-locales@gnu.org"
>  tel        ""
> @@ -81,24 +81,24 @@ day     "dimanche";/
>         "jeudi";/
>         "vendredi";/
>         "samedi"
> -abmon   "jan";"f<U00E9>v";/
> +abmon   "jan";"fév";/
>         "mar";"avr";/
>         "mai";"jun";/
> -       "jui";"ao<U00FB>";/
> +       "jui";"aoû";/
>         "sep";"oct";/
> -       "nov";"d<U00E9>c"
> +       "nov";"déc"
>  mon     "janvier";/
> -       "f<U00E9>vrier";/
> +       "février";/
>         "mars";/
>         "avril";/
>         "mai";/
>         "juin";/
>         "juillet";/
> -       "ao<U00FB>t";/
> +       "août";/
>         "septembre";/
>         "octobre";/
>         "novembre";/
> -       "d<U00E9>cembre"
> +       "décembre"
>  d_t_fmt  "%a %d %b %Y %T"
>  date_fmt "%a %d %b %Y %T %Z"
>  d_fmt   "%d. %m. %y"
> @@ -134,7 +134,7 @@ country_ab2 "CH"
>  country_ab3 "CHE"
>  country_num 756
>  country_car "CH"
> -lang_name "fran<U00E7>ais"
> +lang_name "français"
>  lang_ab      "fr"
>  lang_term    "fra"
>  lang_lib  "fre"
> diff --git a/localedata/locales/fr_FR b/localedata/locales/fr_FR
> index b0cfdce99d..6f733fa035 100644
> --- a/localedata/locales/fr_FR
> +++ b/localedata/locales/fr_FR
> @@ -76,9 +76,9 @@ END LC_MESSAGES
>
>  LC_MONETARY
>  int_curr_symbol           "EUR "
> -currency_symbol           "<U20AC>"
> +currency_symbol           "€"
>  mon_decimal_point         ","
> -mon_thousands_sep         "<U202F>"
> +mon_thousands_sep         " "

NNBSP, looks ok

>
>
>  mon_grouping              3
>  positive_sign             ""
>  negative_sign             "-"
> @@ -94,7 +94,7 @@ END LC_MONETARY
>
>  LC_NUMERIC
>  decimal_point             ","
> -thousands_sep             "<U202F>"
> +thousands_sep             " "

NNBSP, looks ok

>  grouping                  3
>  END LC_NUMERIC
>
> @@ -108,29 +108,29 @@ day     "dimanche";/
>          "vendredi";/
>          "samedi"
>  abmon   "janv.";/
> -        "f<U00E9>vr.";/
> +        "févr.";/
>          "mars";/
>          "avril";/
>          "mai";/
>          "juin";/
>          "juil.";/
> -        "ao<U00FB>t";/
> +        "août";/
>          "sept.";/
>          "oct.";/
>          "nov.";/
> -        "d<U00E9>c."
> +        "déc."
>  mon     "janvier";/
> -        "f<U00E9>vrier";/
> +        "février";/
>          "mars";/
>          "avril";/
>          "mai";/
>          "juin";/
>          "juillet";/
> -        "ao<U00FB>t";/
> +        "août";/
>          "septembre";/
>          "octobre";/
>          "novembre";/
> -        "d<U00E9>cembre"
> +        "décembre"
>  d_t_fmt  "%a %d %b %Y %T"
>  date_fmt "%a %d %b %Y %T %Z"
>  d_fmt   "%d//%m//%Y"
> @@ -169,7 +169,7 @@ country_ab3 "FRA"
>  country_num 250
>  country_isbn "979-10"
>  country_car  "F"
> -lang_name "fran<U00E7>ais"
> +lang_name "français"
>  lang_ab      "fr"
>  lang_term    "fra"
>  lang_lib  "fre"
> diff --git a/localedata/locales/fr_LU b/localedata/locales/fr_LU
> index 777469af07..77272920f7 100644
> --- a/localedata/locales/fr_LU
> +++ b/localedata/locales/fr_LU
> @@ -25,7 +25,7 @@ escape_char /
>  LC_IDENTIFICATION
>  title      "French locale for Luxemburg"
>  source     "RAP"
> -address    "Sankt J<U00F8>rgens Alle 8, DK-1615 K<U00F8>benhavn V, Danmark"
> +address    "Sankt Jørgens Alle 8, DK-1615 København V, Danmark"
>  contact    ""
>  email      "bug-glibc-locales@gnu.org"
>  tel        ""
> @@ -66,9 +66,9 @@ END LC_MESSAGES
>
>  LC_MONETARY
>  int_curr_symbol           "EUR "
> -currency_symbol           "<U20AC>"
> +currency_symbol           "€"
>  mon_decimal_point         ","
> -mon_thousands_sep         "<U202F>"
> +mon_thousands_sep         " "

NNBSP, looks ok

>  mon_grouping              3;3
>  positive_sign             ""
>  negative_sign             "-"
> @@ -84,7 +84,7 @@ END LC_MONETARY
>
>  LC_NUMERIC
>  decimal_point             ","
> -thousands_sep             "<U202F>"
> +thousands_sep             " "

NNBSP, looks ok

>  grouping                  3;3
>  END LC_NUMERIC
>
> @@ -97,24 +97,24 @@ day     "dimanche";/
>         "jeudi";/
>         "vendredi";/
>         "samedi"
> -abmon   "jan";"f<U00E9>v";/
> +abmon   "jan";"fév";/
>         "mar";"avr";/
>         "mai";"jun";/
> -       "jui";"ao<U00FB>";/
> +       "jui";"aoû";/
>         "sep";"oct";/
> -       "nov";"d<U00E9>c"
> +       "nov";"déc"
>  mon     "janvier";/
> -       "f<U00E9>vrier";/
> +       "février";/
>         "mars";/
>         "avril";/
>         "mai";/
>         "juin";/
>         "juillet";/
> -       "ao<U00FB>t";/
> +       "août";/
>         "septembre";/
>         "octobre";/
>         "novembre";/
> -       "d<U00E9>cembre"
> +       "décembre"
>  d_t_fmt  "%a %d %b %Y %T"
>  date_fmt "%a %d %b %Y %T %Z"
>  d_fmt   "%d.%m.%Y"
> @@ -150,7 +150,7 @@ country_ab2 "LU"
>  country_ab3 "LUX"
>  country_num 442
>  country_car "L"
> -lang_name "fran<U00E7>ais"
> +lang_name "français"
>  lang_ab      "fr"
>  lang_term    "fra"
>  lang_lib  "fre"
>
> base-commit: 2955ef4b7c9b56fcd7abfeddef7ee83c60abff98
>

Although I'm not an expert for CA and BE writing convention, I'd
recommend to double check the following:

For CA:
thousand_sep

I note that the "mon_thousand_sep" was "<U202F>" which becomes " " as
expected, but there is no visible change on "thousand_sep" in this
patch. That may be expected, but is worth verifying.

For BE:
mon_thousand_sep
thousand_sep

None of these separators seem to appear in this patch, that may need a
double check.

Besides that, in principle that looks good to me.

Fred.


  reply	other threads:[~2022-08-17  8:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17  7:54 Florian Weimer
2022-08-17  8:57 ` Frederic Berat [this message]
2022-08-17  9:05   ` Florian Weimer
2022-08-17  9:12     ` Frederic Berat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAObJKZoAhv3OhN2eDWK9S0L=3jF=+zMSBP5RchkThT0XxxwRZg@mail.gmail.com' \
    --to=fberat@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).