public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Frederic Berat <fberat@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] localedata: Convert French language locales (fr_*) to UTF_8
Date: Wed, 17 Aug 2022 11:12:20 +0200	[thread overview]
Message-ID: <CAObJKZp+xkv7QnijkBetd3kixPxiu-6EEF4SRHESbC2VtO_HMw@mail.gmail.com> (raw)
In-Reply-To: <87bksj44uh.fsf@oldenburg.str.redhat.com>

Perfect then, thanks.

If it's worth anything:

Reviewed-by: Frédéric Bérat <fberat@redhat.com>

On Wed, Aug 17, 2022 at 11:06 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Frederic Berat:
>
> > Although I'm not an expert for CA and BE writing convention, I'd
> > recommend to double check the following:
> >
> > For CA:
> > thousand_sep
> >
> > I note that the "mon_thousand_sep" was "<U202F>" which becomes " " as
> > expected, but there is no visible change on "thousand_sep" in this
> > patch. That may be expected, but is worth verifying.
>
> fr_CA copies the data from fr_FR, so it inherits the change there:
>
> | LC_NUMERIC
> | copy "fr_FR"
> | END LC_NUMERIC
>
> > For BE:
> > mon_thousand_sep
> > thousand_sep
> >
> > None of these separators seem to appear in this patch, that may need a
> > double check.
>
> fr_BE uses ".", which is ASCII; no change required.
>
> Thanks,
> Florian
>


      reply	other threads:[~2022-08-17  9:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17  7:54 Florian Weimer
2022-08-17  8:57 ` Frederic Berat
2022-08-17  9:05   ` Florian Weimer
2022-08-17  9:12     ` Frederic Berat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAObJKZp+xkv7QnijkBetd3kixPxiu-6EEF4SRHESbC2VtO_HMw@mail.gmail.com \
    --to=fberat@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).