Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

[JOSHI, RAHUL]

Hi Weimer, we have changes ready in glibc to return TTL for resolved IP addresses in 'getaddrinfo'. Can you please let me know what is the procedure to raise a request with a patch??

Thanks,
Rahul

Re: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

[Florian Weimer]

* RAHUL JOSHI:

> Hi Weimer, we have changes ready in glibc to return TTL for resolved
> IP addresses in 'getaddrinfo'. Can you please let me know what is the
> procedure to raise a request with a patch??

The first step is to ensure that you have permission to post your work
publicly.  This something that you need to clarify with your employer.
Once that is done, you can post your patch.

It is likely that your patch will require FSF copyright assignment, as
described here:

<https://sourceware.org/glibc/wiki/Contribution%20checklist#FSF_copyright_assignment>

I do not have access to the FSF records and do not know if HPE already
has a copyright assignment on file.

Thanks,
Florian

RE: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

[JOSHI, RAHUL]

From: JOSHI, RAHUL
Sent: Wednesday, May 05, 2021 1:57 PM
To: 'libc-help@sourceware.org' <libc-help@sourceware.org>
Subject: RE: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

Hi all, is there any update on this??

Thanks,
Rahul

From: JOSHI, RAHUL
Sent: Monday, May 03, 2021 11:30 AM
To: libc-help@sourceware.org<mailto:libc-help@sourceware.org>
Subject: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

Hi all, in current implementation of 'getaddrinfo' or 'getaddrinfo_a' , the TTL(expiry time) of resolved IP addresses isn't provided. Is there any alternate API in libc which will provide resolved IP addresses along with TTL??

If no, what needs to be done to get the resolved addresses along with TTL??

Thanks,
Rahul

RE: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

[JOSHI, RAHUL]

-----Original Message-----
From: JOSHI, RAHUL 
Sent: Wednesday, May 05, 2021 2:26 PM
To: Florian Weimer <fweimer@redhat.com>
Subject: RE: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

Thanks Weimer for the response, I did look into the glibc code and the TTL is already calculated(as minimum TTL value among list of resolved addresses) by some of the API but not accessed by 'getaddrinfo' (passed NULL as argument to TTL pointer). Is it better to modify existing getaddrinfo API or have a similar API to it??

And can I make changes to glibc and if yes, is there any reference or procedure to do that??

Thanks,
Rahul

-----Original Message-----
From: Florian Weimer [mailto:fweimer@redhat.com]
Sent: Wednesday, May 05, 2021 2:10 PM
To: JOSHI, RAHUL via Libc-help <libc-help@sourceware.org>
Cc: JOSHI, RAHUL <rahulj@hpe.com>
Subject: Re: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

* RAHUL via Libc-help JOSHI:

> Hi all, in current implementation of 'getaddrinfo' or 'getaddrinfo_a'
> , the TTL(expiry time) of resolved IP addresses isn't provided. Is 
> there any alternate API in libc which will provide resolved IP 
> addresses along with TTL??
>
> If no, what needs to be done to get the resolved addresses along with 
> TTL??

We can't put the TTL directly into struct addrinfo because we shouldn't change its size.  We'd have to add an accessor function and change the way getaddrinfo allocates the result list.  Fortunately, there is a freeaddrinfo function, so we can maintain a data structure on the side that keeps track of TTLs, for use by the accessor function.

It's not super-hard, but also not exactly trivial, either.  I'm not aware of anyone working on this feature, but it is requested from time to time, so it would be a nice addition to glibc.

Thanks,
Florian

RE: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

[JOSHI, RAHUL]

Sorry Weimer I didn't get what you suggested previously, did you mean allocating memory for TTL after allocating result list??

Example :
If 2 addresses have been resolved, then the allocation for result should be

2 * sizeof(addrinfo) + allocate memory for TTL

Is my understanding correct??

Thanks,
Rahul

-----Original Message-----
From: JOSHI, RAHUL 
Sent: Wednesday, May 05, 2021 3:11 PM
To: 'Florian Weimer' <fweimer@redhat.com>
Cc: 'libc-help@sourceware.org' <libc-help@sourceware.org>; 'libc-alpha@sourceware.org' <libc-alpha@sourceware.org>
Subject: RE: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'



-----Original Message-----
From: JOSHI, RAHUL
Sent: Wednesday, May 05, 2021 2:26 PM
To: Florian Weimer <fweimer@redhat.com>
Subject: RE: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

Thanks Weimer for the response, I did look into the glibc code and the TTL is already calculated(as minimum TTL value among list of resolved addresses) by some of the API but not accessed by 'getaddrinfo' (passed NULL as argument to TTL pointer). Is it better to modify existing getaddrinfo API or have a similar API to it??

And can I make changes to glibc and if yes, is there any reference or procedure to do that??

Thanks,
Rahul

-----Original Message-----
From: Florian Weimer [mailto:fweimer@redhat.com]
Sent: Wednesday, May 05, 2021 2:10 PM
To: JOSHI, RAHUL via Libc-help <libc-help@sourceware.org>
Cc: JOSHI, RAHUL <rahulj@hpe.com>
Subject: Re: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

* RAHUL via Libc-help JOSHI:

> Hi all, in current implementation of 'getaddrinfo' or 'getaddrinfo_a'
> , the TTL(expiry time) of resolved IP addresses isn't provided. Is 
> there any alternate API in libc which will provide resolved IP 
> addresses along with TTL??
>
> If no, what needs to be done to get the resolved addresses along with 
> TTL??

We can't put the TTL directly into struct addrinfo because we shouldn't change its size.  We'd have to add an accessor function and change the way getaddrinfo allocates the result list.  Fortunately, there is a freeaddrinfo function, so we can maintain a data structure on the side that keeps track of TTLs, for use by the accessor function.

It's not super-hard, but also not exactly trivial, either.  I'm not aware of anyone working on this feature, but it is requested from time to time, so it would be a nice addition to glibc.

Thanks,
Florian

RE: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

[JOSHI, RAHUL]

Hi Weimer, is there any update on this??

https://code.woboq.org/userspace/glibc/sysdeps/posix/getaddrinfo.c.html#1068 -> here we need to allocate memory for TTL and access it by accessor function??

Thanks,
Rahul

-----Original Message-----
From: JOSHI, RAHUL 
Sent: Wednesday, May 05, 2021 5:57 PM
To: 'Florian Weimer' <fweimer@redhat.com>
Cc: 'libc-help@sourceware.org' <libc-help@sourceware.org>; 'libc-alpha@sourceware.org' <libc-alpha@sourceware.org>
Subject: RE: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

Sorry Weimer I didn't get what you suggested previously, did you mean allocating memory for TTL after allocating result list??

Example :
If 2 addresses have been resolved, then the allocation for result should be

2 * sizeof(addrinfo) + 2 * allocate memory for TTL

Is my understanding correct??

Thanks,
Rahul

-----Original Message-----
From: JOSHI, RAHUL 
Sent: Wednesday, May 05, 2021 3:11 PM
To: 'Florian Weimer' <fweimer@redhat.com>
Cc: 'libc-help@sourceware.org' <libc-help@sourceware.org>; 'libc-alpha@sourceware.org' <libc-alpha@sourceware.org>
Subject: RE: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'



-----Original Message-----
From: JOSHI, RAHUL
Sent: Wednesday, May 05, 2021 2:26 PM
To: Florian Weimer <fweimer@redhat.com>
Subject: RE: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

Thanks Weimer for the response, I did look into the glibc code and the TTL is already calculated(as minimum TTL value among list of resolved addresses) by some of the API but not accessed by 'getaddrinfo' (passed NULL as argument to TTL pointer). Is it better to modify existing getaddrinfo API or have a similar API to it??

And can I make changes to glibc and if yes, is there any reference or procedure to do that??

Thanks,
Rahul

-----Original Message-----
From: Florian Weimer [mailto:fweimer@redhat.com]
Sent: Wednesday, May 05, 2021 2:10 PM
To: JOSHI, RAHUL via Libc-help <libc-help@sourceware.org>
Cc: JOSHI, RAHUL <rahulj@hpe.com>
Subject: Re: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

* RAHUL via Libc-help JOSHI:

> Hi all, in current implementation of 'getaddrinfo' or 'getaddrinfo_a'
> , the TTL(expiry time) of resolved IP addresses isn't provided. Is 
> there any alternate API in libc which will provide resolved IP 
> addresses along with TTL??
>
> If no, what needs to be done to get the resolved addresses along with 
> TTL??

We can't put the TTL directly into struct addrinfo because we shouldn't change its size.  We'd have to add an accessor function and change the way getaddrinfo allocates the result list.  Fortunately, there is a freeaddrinfo function, so we can maintain a data structure on the side that keeps track of TTLs, for use by the accessor function.

It's not super-hard, but also not exactly trivial, either.  I'm not aware of anyone working on this feature, but it is requested from time to time, so it would be a nice addition to glibc.

Thanks,
Florian

Re: Having TTL of resolved IP addresses in 'getaddrinfo' or 'getaddrinfo_a'

[Florian Weimer]

* RAHUL JOSHI:

> Hi Weimer, is there any update on this??
>
> https://code.woboq.org/userspace/glibc/sysdeps/posix/getaddrinfo.c.html#1068 -> here we need to allocate memory for TTL and access it by accessor function??
>
> Thanks,
> Rahul

Probably, and maybe use some separate data structure to keep track of
struct addrinfo pointer values for which the TTL field is actually
available.

Thanks,
Florian