* [PATCH] powerpc: add tests for __ppc_set_ppr_* functions.
@ 2016-12-22 12:13 Wainer dos Santos Moschetta
2016-12-22 15:06 ` Carlos Eduardo Seo
2016-12-28 12:42 ` [PATCH] " Tulio Magno Quites Machado Filho
0 siblings, 2 replies; 4+ messages in thread
From: Wainer dos Santos Moschetta @ 2016-12-22 12:13 UTC (permalink / raw)
To: libc-alpha
sys/platform/ppc.h defines a class of __ppc_set_ppr functions
used to set the Program Priority Register (PPR) in powerpc.
This patch implements test cases for these functions.
Tested on ppc64le.
2016-12-20 Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com>
* sysdeps/powerpc/tst-set_ppr.c: New file.
Implement test cases for __ppc_set_ppr_* functions.
* sysdeps/powerpc/Makefile ($(subdir),misc): Add tst-set_ppr
in the list of tests.
---
sysdeps/powerpc/Makefile | 1 +
sysdeps/powerpc/tst-set_ppr.c | 76 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 77 insertions(+)
create mode 100644 sysdeps/powerpc/tst-set_ppr.c
diff --git a/sysdeps/powerpc/Makefile b/sysdeps/powerpc/Makefile
index 099fbf6..933810f 100644
--- a/sysdeps/powerpc/Makefile
+++ b/sysdeps/powerpc/Makefile
@@ -34,6 +34,7 @@ endif
ifeq ($(subdir),misc)
sysdep_headers += sys/platform/ppc.h
tests += test-gettimebase
+tests += tst-set_ppr
endif
ifneq (,$(filter %le,$(config-machine)))
diff --git a/sysdeps/powerpc/tst-set_ppr.c b/sysdeps/powerpc/tst-set_ppr.c
new file mode 100644
index 0000000..4c89fd4
--- /dev/null
+++ b/sysdeps/powerpc/tst-set_ppr.c
@@ -0,0 +1,76 @@
+/* Test the implementation of __ppc_set_ppr_* functions.
+ Copyright (C) 2016 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <inttypes.h>
+#include <stdio.h>
+#include <stdint.h>
+
+#include <sys/platform/ppc.h>
+
+/* Read the value of the Program Priority Register (PPR). */
+static __inline__ uint64_t
+read_ppr (void)
+{
+ /* Represents the full 64-bits length register. */
+ uint64_t ppr;
+ asm volatile ("mfppr %0" : "=r"(ppr));
+ return ppr;
+}
+
+/* Check the thread priority bits of PPR are set as expected. */
+uint8_t
+check_thread_priority (uint8_t expected, uint64_t ppr)
+{
+ /* The thread priority value is set on bits 11:13. */
+ uint64_t p = ((ppr >> 50) & 7);
+ if (p != expected)
+ {
+ printf ("FAIL: Expected %"PRIu8" got %"PRIu64".\n", expected, p);
+ return 1;
+ }
+ printf ("PASS: Thread priority set to %"PRIu64" correctly.\n", p);
+ return 0;
+}
+
+/* The Power ISA 2.07b allows the following thread priorities for any
+ problem state program: 1 (very low), 2 (low), 3 (medium low),
+ and 4 (medium).
+ Check whether the values set by __ppc_set_ppr_* are correct. */
+static int
+do_test (void)
+{
+ uint8_t rc = 0;
+
+#ifdef _ARCH_PWR8
+ __ppc_set_ppr_very_low ();
+ rc |= check_thread_priority (1, read_ppr());
+#endif /* _ARCH_PWR8 */
+
+ __ppc_set_ppr_low ();
+ rc |= check_thread_priority (2, read_ppr());
+
+ __ppc_set_ppr_med_low ();
+ rc |= check_thread_priority (3, read_ppr());
+
+ __ppc_set_ppr_med ();
+ rc |= check_thread_priority (4, read_ppr());
+
+ return rc;
+}
+
+#include <support/test-driver.c>
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: add tests for __ppc_set_ppr_* functions.
2016-12-22 12:13 [PATCH] powerpc: add tests for __ppc_set_ppr_* functions Wainer dos Santos Moschetta
@ 2016-12-22 15:06 ` Carlos Eduardo Seo
2016-12-23 14:36 ` [PATCH v2] " Wainer dos Santos Moschetta
2016-12-28 12:42 ` [PATCH] " Tulio Magno Quites Machado Filho
1 sibling, 1 reply; 4+ messages in thread
From: Carlos Eduardo Seo @ 2016-12-22 15:06 UTC (permalink / raw)
To: Wainer dos Santos Moschetta; +Cc: libc-alpha
On 12/22/16, 10:13 AM, "Wainer dos Santos Moschetta" <libc-alpha-owner@sourceware.org on behalf of wainersm@linux.vnet.ibm.com> wrote:
diff --git a/sysdeps/powerpc/tst-set_ppr.c b/sysdeps/powerpc/tst-set_ppr.c
new file mode 100644
index 0000000..4c89fd4
--- /dev/null
+++ b/sysdeps/powerpc/tst-set_ppr.c
@@ -0,0 +1,76 @@
+/* Test the implementation of __ppc_set_ppr_* functions.
s/Test/Tests/
Other than that, LGTM.
--
Carlos Eduardo Seo
Software Engineer - Linux on Power Toolchain
cseo@linux.vnet.ibm.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] powerpc: add tests for __ppc_set_ppr_* functions.
2016-12-22 15:06 ` Carlos Eduardo Seo
@ 2016-12-23 14:36 ` Wainer dos Santos Moschetta
0 siblings, 0 replies; 4+ messages in thread
From: Wainer dos Santos Moschetta @ 2016-12-23 14:36 UTC (permalink / raw)
To: libc-alpha
Changes since v1:
- Replaced "Test" with "Test" on first line of comment.
-- >8 --
sys/platform/ppc.h defines a class of __ppc_set_ppr functions
used to set the Program Priority Register (PPR) in powerpc.
This patch implements test cases for these functions.
Tested on ppc64le.
2016-12-20 Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com>
* sysdeps/powerpc/tst-set_ppr.c: New file.
Implement test cases for __ppc_set_ppr_* functions.
* sysdeps/powerpc/Makefile ($(subdir),misc): Add tst-set_ppr
in the list of tests.
---
sysdeps/powerpc/Makefile | 1 +
sysdeps/powerpc/tst-set_ppr.c | 76 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 77 insertions(+)
create mode 100644 sysdeps/powerpc/tst-set_ppr.c
diff --git a/sysdeps/powerpc/Makefile b/sysdeps/powerpc/Makefile
index 099fbf6..933810f 100644
--- a/sysdeps/powerpc/Makefile
+++ b/sysdeps/powerpc/Makefile
@@ -34,6 +34,7 @@ endif
ifeq ($(subdir),misc)
sysdep_headers += sys/platform/ppc.h
tests += test-gettimebase
+tests += tst-set_ppr
endif
ifneq (,$(filter %le,$(config-machine)))
diff --git a/sysdeps/powerpc/tst-set_ppr.c b/sysdeps/powerpc/tst-set_ppr.c
new file mode 100644
index 0000000..6c1bf6c
--- /dev/null
+++ b/sysdeps/powerpc/tst-set_ppr.c
@@ -0,0 +1,76 @@
+/* Tests the implementation of __ppc_set_ppr_* functions.
+ Copyright (C) 2016 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <inttypes.h>
+#include <stdio.h>
+#include <stdint.h>
+
+#include <sys/platform/ppc.h>
+
+/* Read the value of the Program Priority Register (PPR). */
+static __inline__ uint64_t
+read_ppr (void)
+{
+ /* Represents the full 64-bits length register. */
+ uint64_t ppr;
+ asm volatile ("mfppr %0" : "=r"(ppr));
+ return ppr;
+}
+
+/* Check the thread priority bits of PPR are set as expected. */
+uint8_t
+check_thread_priority (uint8_t expected, uint64_t ppr)
+{
+ /* The thread priority value is set on bits 11:13. */
+ uint64_t p = ((ppr >> 50) & 7);
+ if (p != expected)
+ {
+ printf ("FAIL: Expected %"PRIu8" got %"PRIu64".\n", expected, p);
+ return 1;
+ }
+ printf ("PASS: Thread priority set to %"PRIu64" correctly.\n", p);
+ return 0;
+}
+
+/* The Power ISA 2.07b allows the following thread priorities for any
+ problem state program: 1 (very low), 2 (low), 3 (medium low),
+ and 4 (medium).
+ Check whether the values set by __ppc_set_ppr_* are correct. */
+static int
+do_test (void)
+{
+ uint8_t rc = 0;
+
+#ifdef _ARCH_PWR8
+ __ppc_set_ppr_very_low ();
+ rc |= check_thread_priority (1, read_ppr());
+#endif /* _ARCH_PWR8 */
+
+ __ppc_set_ppr_low ();
+ rc |= check_thread_priority (2, read_ppr());
+
+ __ppc_set_ppr_med_low ();
+ rc |= check_thread_priority (3, read_ppr());
+
+ __ppc_set_ppr_med ();
+ rc |= check_thread_priority (4, read_ppr());
+
+ return rc;
+}
+
+#include <support/test-driver.c>
--
2.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: add tests for __ppc_set_ppr_* functions.
2016-12-22 12:13 [PATCH] powerpc: add tests for __ppc_set_ppr_* functions Wainer dos Santos Moschetta
2016-12-22 15:06 ` Carlos Eduardo Seo
@ 2016-12-28 12:42 ` Tulio Magno Quites Machado Filho
1 sibling, 0 replies; 4+ messages in thread
From: Tulio Magno Quites Machado Filho @ 2016-12-28 12:42 UTC (permalink / raw)
To: Wainer dos Santos Moschetta, libc-alpha
Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com> writes:
> sys/platform/ppc.h defines a class of __ppc_set_ppr functions
> used to set the Program Priority Register (PPR) in powerpc.
> This patch implements test cases for these functions.
>
> Tested on ppc64le.
LGTM in overall, but....
> +/* Read the value of the Program Priority Register (PPR). */
> +static __inline__ uint64_t
> +read_ppr (void)
> +{
> + /* Represents the full 64-bits length register. */
> + uint64_t ppr;
> + asm volatile ("mfppr %0" : "=r"(ppr));
This won't work on 32 bits. You have to use mfppr32.
> + return ppr;
> +}
> +
> +/* Check the thread priority bits of PPR are set as expected. */
> +uint8_t
> +check_thread_priority (uint8_t expected, uint64_t ppr)
> +{
> + /* The thread priority value is set on bits 11:13. */
> + uint64_t p = ((ppr >> 50) & 7);
This also needs to be changed.
--
Tulio Magno
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-28 12:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-22 12:13 [PATCH] powerpc: add tests for __ppc_set_ppr_* functions Wainer dos Santos Moschetta
2016-12-22 15:06 ` Carlos Eduardo Seo
2016-12-23 14:36 ` [PATCH v2] " Wainer dos Santos Moschetta
2016-12-28 12:42 ` [PATCH] " Tulio Magno Quites Machado Filho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).