From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: "Tang, Jun" <juntangc@amazon.com>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: Re: patch for hp-timing.h
Date: Wed, 8 Feb 2023 14:58:39 +0000 [thread overview]
Message-ID: <PAWPR08MB89825AC8BFDF42BF479ADB7983D89@PAWPR08MB8982.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <aa3b37b204d44bd98070cfc5566d65f4@amazon.com>
Hi Jun,
> There are 7 zero bits at the end of freq (1050000000). So the time can be extended to
> 2048 second before losing resolution. Below is the updated patch for 1024 sec -
>
> - (Diff) = ((End) - (Start)) * (UINT64_C(1000000000) / freq); \
> + (Diff) = (((End) - (Start)) * UINT64_C(1000000000>>6)) / (freq>>6); \
Minor codestyle: there should be a space before/after '>>'.
Apart from that it looks good and works fine.
Can you resend an updated patch with comment header etc in a new email with
subject like "[PATCH v2] AArch64: Fix HP_TIMING_DIFF computation" or similar?
I guess this is your first patch and you don't have commit rights?
Cheers,
Wilco
next prev parent reply other threads:[~2023-02-08 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:29 Wilco Dijkstra
2023-02-03 13:38 ` Adhemerval Zanella Netto
2023-02-03 14:02 ` Tang, Jun
2023-02-06 16:53 ` Wilco Dijkstra
2023-02-06 19:34 ` Tang, Jun
2023-02-08 14:58 ` Wilco Dijkstra [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-31 23:20 Tang, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAWPR08MB89825AC8BFDF42BF479ADB7983D89@PAWPR08MB8982.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=juntangc@amazon.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).