From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] arm: Remove __builtin_arm_uqsub8 usage on string-fza.h
Date: Wed, 1 Mar 2023 13:47:59 +0000 [thread overview]
Message-ID: <PAWPR08MB898264046E98DB70C12607C383AD9@PAWPR08MB8982.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20230228182325.3127358-1-adhemerval.zanella@linaro.org>
Hi Adhemerval,
> The __builtin_arm_uqsub8 is an internal GCC builtin which might change
> in future release (the correct way is to include "arm_acle.h" and use
> __uqsub8 ()). Since not all compilers support it, just use the
> inline assembler instead.
LGTM.
Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
@@ -33,13 +33,9 @@ find_zero_all (op_t x)
/* Use unsigned saturated subtraction from 1 in each byte.
That leaves 1 for every byte that was zero. */
op_t ones = repeat_bytes (0x01);
-#if __GNUC_PREREQ (10, 0)
- return __builtin_arm_uqsub8 (ones, x);
-#else
op_t ret;
asm ("uqsub8 %0,%1,%2" : "=r"(ret) : "r"(ones), "r"(x));
return ret;
-#endif
}
OK
prev parent reply other threads:[~2023-03-01 13:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 18:23 Adhemerval Zanella
2023-03-01 13:47 ` Wilco Dijkstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAWPR08MB898264046E98DB70C12607C383AD9@PAWPR08MB8982.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).