* [PATCH] arm: Remove __builtin_arm_uqsub8 usage on string-fza.h
@ 2023-02-28 18:23 Adhemerval Zanella
2023-03-01 13:47 ` Wilco Dijkstra
0 siblings, 1 reply; 2+ messages in thread
From: Adhemerval Zanella @ 2023-02-28 18:23 UTC (permalink / raw)
To: libc-alpha, Wilco Dijkstra
The __builtin_arm_uqsub8 is an internal GCC builtin which might change
in future release (the correct way is to include "arm_acle.h" and use
__uqsub8 ()). Since not all compilers support it, just use the
inline assembler instead.
Checked on armv7a-linux-gnueabihf.
---
sysdeps/arm/armv6t2/string-fza.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/sysdeps/arm/armv6t2/string-fza.h b/sysdeps/arm/armv6t2/string-fza.h
index d85ce86434..fb75011991 100644
--- a/sysdeps/arm/armv6t2/string-fza.h
+++ b/sysdeps/arm/armv6t2/string-fza.h
@@ -33,13 +33,9 @@ find_zero_all (op_t x)
/* Use unsigned saturated subtraction from 1 in each byte.
That leaves 1 for every byte that was zero. */
op_t ones = repeat_bytes (0x01);
-#if __GNUC_PREREQ (10, 0)
- return __builtin_arm_uqsub8 (ones, x);
-#else
op_t ret;
asm ("uqsub8 %0,%1,%2" : "=r"(ret) : "r"(ones), "r"(x));
return ret;
-#endif
}
/* Identify bytes that are equal between X1 and X2. */
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arm: Remove __builtin_arm_uqsub8 usage on string-fza.h
2023-02-28 18:23 [PATCH] arm: Remove __builtin_arm_uqsub8 usage on string-fza.h Adhemerval Zanella
@ 2023-03-01 13:47 ` Wilco Dijkstra
0 siblings, 0 replies; 2+ messages in thread
From: Wilco Dijkstra @ 2023-03-01 13:47 UTC (permalink / raw)
To: Adhemerval Zanella, libc-alpha
Hi Adhemerval,
> The __builtin_arm_uqsub8 is an internal GCC builtin which might change
> in future release (the correct way is to include "arm_acle.h" and use
> __uqsub8 ()). Since not all compilers support it, just use the
> inline assembler instead.
LGTM.
Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
@@ -33,13 +33,9 @@ find_zero_all (op_t x)
/* Use unsigned saturated subtraction from 1 in each byte.
That leaves 1 for every byte that was zero. */
op_t ones = repeat_bytes (0x01);
-#if __GNUC_PREREQ (10, 0)
- return __builtin_arm_uqsub8 (ones, x);
-#else
op_t ret;
asm ("uqsub8 %0,%1,%2" : "=r"(ret) : "r"(ones), "r"(x));
return ret;
-#endif
}
OK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-01 13:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-28 18:23 [PATCH] arm: Remove __builtin_arm_uqsub8 usage on string-fza.h Adhemerval Zanella
2023-03-01 13:47 ` Wilco Dijkstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).