public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
	"H . J . Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH v4 1/5] benchtests: Add fmod benchmark
Date: Mon, 3 Apr 2023 13:13:35 +0000	[thread overview]
Message-ID: <PAWPR08MB8982B1AB0FCF0C35AC2B66DB83929@PAWPR08MB8982.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20230320160118.352206-2-adhemerval.zanella@linaro.org>

Hi Adhemerval,

LGTM (in the future we should aim to add traces when we can
get them)

Reviewed-by: Wilco Dijkstra  <Wilco.Dijkstra@arm.com>

Cheers,
Wilco

> Add three different dataset, from random floating point numbers:
>
> 1. Subnormals: 128 inputs.
> 2. Normal numbers with large exponent difference (|x/y| > 2^52):
>    1024 inputs between DBL_MIN and DBL_MAX;
> 3. Close exponents (ey >= -907 and |x/y| < 2^52): 1024 inputs with
>   exponents between -10 and 10.


  reply	other threads:[~2023-04-03 13:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 16:01 [PATCH v4 0/5] Improve fmod and fmodf Adhemerval Zanella
2023-03-20 16:01 ` [PATCH v4 1/5] benchtests: Add fmod benchmark Adhemerval Zanella
2023-04-03 13:13   ` Wilco Dijkstra [this message]
2023-03-20 16:01 ` [PATCH v4 2/5] benchtests: Add fmodf benchmark Adhemerval Zanella
2023-04-03 13:16   ` Wilco Dijkstra
2023-03-20 16:01 ` [PATCH v4 3/5] math: Improve fmod Adhemerval Zanella
2023-04-03 13:29   ` Wilco Dijkstra
2023-03-20 16:01 ` [PATCH v4 4/5] math: Improve fmodf Adhemerval Zanella
2023-04-03 13:33   ` Wilco Dijkstra
2023-03-20 16:01 ` [PATCH v4 5/5] math: Remove the error handling wrapper from fmod and fmodf Adhemerval Zanella
2023-04-03 13:43   ` Wilco Dijkstra
2023-04-03 18:33     ` Adhemerval Zanella Netto
  -- strict thread matches above, loose matches on Subject: below --
2023-03-20 13:47 [PATCH v4 0/5] Improve " Adhemerval Zanella
2023-03-20 13:47 ` [PATCH v4 1/5] benchtests: Add fmod benchmark Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PAWPR08MB8982B1AB0FCF0C35AC2B66DB83929@PAWPR08MB8982.eurprd08.prod.outlook.com \
    --to=wilco.dijkstra@arm.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).