From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
"H . J . Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH v4 5/5] math: Remove the error handling wrapper from fmod and fmodf
Date: Mon, 3 Apr 2023 15:33:46 -0300 [thread overview]
Message-ID: <3064c4e8-beb4-126f-e2b4-81b1acbd3b91@linaro.org> (raw)
In-Reply-To: <PAWPR08MB898249921EC7DE26E77B837583929@PAWPR08MB8982.eurprd08.prod.outlook.com>
On 03/04/23 10:43, Wilco Dijkstra wrote:
> Hi Adhemerval,
>
> LGTM - one minor nit about the is_inf functions, are they actually needed?
> I'm happy for this to go in either way.
>
> Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
>
> Cheers,
> Wilco
>
> diff --git a/sysdeps/ieee754/flt-32/math_config.h b/sysdeps/ieee754/flt-32/math_config.h
> index 829430ea28..f97cd39df1 100644
> --- a/sysdeps/ieee754/flt-32/math_config.h
> +++ b/sysdeps/ieee754/flt-32/math_config.h
> @@ -125,6 +125,12 @@ is_nan (uint32_t x)
> return (x & EXP_MANT_MASK) > EXPONENT_MASK;
> }
>
> +static inline bool
> +is_inf (uint32_t x)
> +{
> + return (x & EXP_MANT_MASK) == EXPONENT_MASK;
> +}
>
> Used?
It is a left-over from previous version, I will remove it.
prev parent reply other threads:[~2023-04-03 18:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 16:01 [PATCH v4 0/5] Improve " Adhemerval Zanella
2023-03-20 16:01 ` [PATCH v4 1/5] benchtests: Add fmod benchmark Adhemerval Zanella
2023-04-03 13:13 ` Wilco Dijkstra
2023-03-20 16:01 ` [PATCH v4 2/5] benchtests: Add fmodf benchmark Adhemerval Zanella
2023-04-03 13:16 ` Wilco Dijkstra
2023-03-20 16:01 ` [PATCH v4 3/5] math: Improve fmod Adhemerval Zanella
2023-04-03 13:29 ` Wilco Dijkstra
2023-03-20 16:01 ` [PATCH v4 4/5] math: Improve fmodf Adhemerval Zanella
2023-04-03 13:33 ` Wilco Dijkstra
2023-03-20 16:01 ` [PATCH v4 5/5] math: Remove the error handling wrapper from fmod and fmodf Adhemerval Zanella
2023-04-03 13:43 ` Wilco Dijkstra
2023-04-03 18:33 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3064c4e8-beb4-126f-e2b4-81b1acbd3b91@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).