From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Kito Cheng <kito.cheng@sifive.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
"joseph@codesourcery.com" <joseph@codesourcery.com>,
"palmer@rivosinc.com" <palmer@rivosinc.com>,
"jeffreyalaw@gmail.com" <jeffreyalaw@gmail.com>,
"darius@bluespec.com" <darius@bluespec.com>,
"christoph.muellner@vrull.eu" <christoph.muellner@vrull.eu>,
"dj@redhat.com" <dj@redhat.com>,
"andrew@sifive.com" <andrew@sifive.com>,
"xry111@xry111.site" <xry111@xry111.site>
Subject: Re: [PATCH v2] Remap __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1
Date: Thu, 16 Mar 2023 18:42:52 +0000 [thread overview]
Message-ID: <PAWPR08MB8982C6C7C1650B468FDCDC9A83BC9@PAWPR08MB8982.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20230314151948.12892-1-kito.cheng@sifive.com>
Hi Kito,
Thanks for the update, this looks good now.
Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cheers,
Wilco
---
bits/flt-eval-method.h | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/bits/flt-eval-method.h b/bits/flt-eval-method.h
index 75f57b9a0e..f9262d7d0b 100644
--- a/bits/flt-eval-method.h
+++ b/bits/flt-eval-method.h
@@ -26,14 +26,12 @@
-1. */
/* In the default version of this header, follow __FLT_EVAL_METHOD__.
- -1 is mapped to 2 (considering evaluation as long double to be a
- conservatively safe assumption), and if __FLT_EVAL_METHOD__ is not
- defined then assume there is no excess precision and use the value
- 0. */
+ If __FLT_EVAL_METHOD__ is not defined or set to -1, assume there is no
+ excess precision and use the value 0 (this is correct for most targets). */
#ifdef __FLT_EVAL_METHOD__
# if __FLT_EVAL_METHOD__ == -1
-# define __GLIBC_FLT_EVAL_METHOD 2
+# define __GLIBC_FLT_EVAL_METHOD 0
# else
# define __GLIBC_FLT_EVAL_METHOD __FLT_EVAL_METHOD__
# endif
--
2.39.2
prev parent reply other threads:[~2023-03-16 18:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 15:19 Kito Cheng
2023-03-16 18:42 ` Wilco Dijkstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAWPR08MB8982C6C7C1650B468FDCDC9A83BC9@PAWPR08MB8982.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=andrew@sifive.com \
--cc=christoph.muellner@vrull.eu \
--cc=darius@bluespec.com \
--cc=dj@redhat.com \
--cc=jeffreyalaw@gmail.com \
--cc=joseph@codesourcery.com \
--cc=kito.cheng@sifive.com \
--cc=libc-alpha@sourceware.org \
--cc=palmer@rivosinc.com \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).