From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 2/6] Benchtests: Add benchtests for __memcmpeq
Date: Wed, 3 Nov 2021 13:39:29 +0000 [thread overview]
Message-ID: <VE1PR08MB5599A1B7F6675F96C3D3C2DB838C9@VE1PR08MB5599.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAFUsyfK7BPdTLi5QNd-DAA=bW7QyGmYQ9rF5FNZ3rKRiSMi4zQ@mail.gmail.com>
Hi Noah,
> > As committed, it's literally the same benchmark as memcmp, however I
> > expected it to call __memcmpeq... You'll need to change the definition of
> > MEMCMP as well.
> Not certain why, but it does seem to be getting the right ifuncs. Can update it
> if desirable.
> Is this also true for 'wmemcmp'? I don't see it defining MEMCMP either.
Ifuncs use TEST_NAME (which is right) while there is also IMPL (MEMCMP, 1)
which is not correct. It is defined in bench-string - it does support wmemcmp,
but it is missing support for __memcmpeq.
Cheers,
Wilco
next prev parent reply other threads:[~2021-11-03 13:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 13:56 Wilco Dijkstra
2021-11-01 16:01 ` Noah Goldstein
2021-11-02 20:57 ` Noah Goldstein
2021-11-03 13:39 ` Wilco Dijkstra [this message]
2021-11-03 17:17 ` Noah Goldstein
-- strict thread matches above, loose matches on Subject: below --
2021-10-27 2:43 [PATCH v1 " Noah Goldstein
2021-10-27 16:07 ` [PATCH v2 " Noah Goldstein
2021-10-27 17:59 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB5599A1B7F6675F96C3D3C2DB838C9@VE1PR08MB5599.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).