Re: Upstreaming OpenRISC with GCC mainline

[Stafford Horne <shorne@gmail.com>]

On Fri, Oct 29, 2021 at 07:18:45AM +0900, Stafford Horne wrote:
> On Thu, Oct 28, 2021 at 09:45:51PM +0000, Joseph Myers wrote:
> > On Fri, 29 Oct 2021, Stafford Horne via Libc-alpha wrote:
> > 
> > > On Thu, Oct 28, 2021 at 05:15:00PM +0000, Joseph Myers wrote:
> > > > On Thu, 28 Oct 2021, Stafford Horne via Libc-alpha wrote:
> > > > 
> > > > > I was seeing failures there and thought the warnings I was seeing were
> > > > > affecting all architectures.  But now I see the builds are mostly clean.
> > > > > So it's something I'll have to track down.
> > > > 
> > > > The only issue I know of at present with GCC mainline is the testsuite 
> > > > build failures for 32-bit platforms that are addressed by my patch 
> > > > <https://sourceware.org/pipermail/libc-alpha/2021-October/132348.html>.
> > > 
> > > Thanks, yes I saw that patch.
> > > 
> > > I am trying to compare builds of multiple architectures.  I do see similar
> > > errors on riscv32.  I am continuing to try looking at other architectures, but
> > > just wanted to note this:
> > > 
> > > FAIL: compilers-riscv32-linux-gnu-rv32imac-ilp32 glibc riscv32-linux-gnu-rv32imac-ilp32 build
> > 
> > Since I don't see this, do you have environment variables set (e.g. 
> > CFLAGS) that might perturb the build?  You're not meant to have such 
> > variables set when running build-many-glibcs.py, and can definitely expect 
> > additional warnings with -O1 or -O3, for example.  (We *should* fix things 
> > to build cleanly with -O1 and -O3 and -Os and -Og, and even -O0, but 
> > that's a separate issue.)
> 
> Thats it, I have -Og setup in my build environment.
> 
> I must have missed where that was mentioned.
> 

Hi Joseph,

Do you store your full output results anywhere for build-many, i.e.

 GCC mainline glibcs 2021-10-28 16:33:56 build results
 - https://sourceware.org/pipermail/libc-testresults/2021q4/008777.html

I am getting these failures now, and am wondering if you see them too:

    $ or1k-glibc-linux-gnu-gcc tst-mqueue5.c -c -std=gnu11 -fgnu89-inline  -g -O -Wall -Wwrite-strings -Wundef -Werror -fmerge-all-constants -frounding-math -fno-stack-protector -fno-c....
    tst-mqueue5.c: In function ‘mqsend’:
    tst-mqueue5.c:61:7: error: ‘c’ may be used uninitialized [-Werror=maybe-uninitialized]
       61 |   if (mq_send (q, &c, 1, 1) != 0)
	  |       ^~~~~~~~~~~~~~~~~~~~~
    In file included from ../include/mqueue.h:1,
		     from tst-mqueue5.c:21:
    ../rt/mqueue.h:70:12: note: by argument 2 of type ‘const char *’ to ‘mq_send’ declared here
       70 | extern int mq_send (mqd_t __mqdes, const char *__msg_ptr, size_t __msg_len,
	  |            ^~~~~~~
    tst-mqueue5.c:60:8: note: ‘c’ declared here
       60 |   char c;
	  |        ^

-Stafford