From: Stafford Horne <shorne@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: GLIBC patches <libc-alpha@sourceware.org>
Subject: Re: Upstreaming OpenRISC with GCC mainline
Date: Tue, 2 Nov 2021 13:18:15 +0900 [thread overview]
Message-ID: <YYC8B61O+ZTRi9Qh@antec> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2111012045280.1978253@digraph.polyomino.org.uk>
On Mon, Nov 01, 2021 at 08:47:04PM +0000, Joseph Myers wrote:
> On Sat, 30 Oct 2021, Stafford Horne via Libc-alpha wrote:
>
> > Error:
> >
> > or1k-glibc-linux-gnu-gcc tst-timespec.c -fdump-analyzer -fdump-lang-all -fdump-tree-all -c -fgnu89-inline -g -O2 -Wall -Wwrite-strings -Wundef -Werror -fmerge-all-constants -frounding-math -fno-stack-protector -fno-common -Wstrict-prototypes -Wold-style-definition -fmath-errno -I../include -I/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/support -I/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc -I../sysdeps/unix/sysv/linux/or1k -I../sysdeps/or1k/nptl -I../sysdeps/unix/sysv/linux/generic/wordsize-32 -I../sysdeps/unix/sysv/linux/generic -I../sysdeps/unix/sysv/linux/include -I../sysdeps/unix/sysv/linux -I../sysdeps/nptl -I../sysdeps/pthread -I../sysdeps/gnu -I../sysdeps/unix/inet -I../sysdeps/unix/sysv -I../sysdeps/unix -I../sysdeps/posix -I../sysdeps/or1k/nofpu -I../sysdeps/ieee754/soft-fp -I../sysdeps/or1k -I../sysdeps/wordsize-32 -I../sysdeps/ieee754/dbl-64 -I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754 -I../sysdeps/generic -I.. -I../libio -I. -D_LIBC_REENTRANT -include /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/libc-modules.h -DMODULE_NAME=testsuite -include ../include/libc-symbols.h -DTOP_NAMESPACE=glibc -o /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/support/tst-timespec.o -MD -MP -MF /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/support/tst-timespec.o.dt -MT /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/support/tst-timespec.o
> > In file included from tst-timespec.c:22:
> > ../include/intprops.h:57:3: error: initializer element is not computable at load time
> > 57 | ((t) (! TYPE_SIGNED (t) \
> > | ^
> > tst-timespec.c:48:20: note: in expansion of macro ‘TYPE_MAXIMUM’
> > 48 | #define TIME_T_MAX TYPE_MAXIMUM (time_t)
> > | ^~~~~~~~~~~~
> > tst-timespec.c:290:19: note: in expansion of macro ‘TIME_T_MAX’
> > 290 | .upper_bound = TIME_T_MAX, .lower_bound = 1, .result = 1,
> > | ^~~~~~~~~~
> > ../include/intprops.h:57:3: note: (near initialization for ‘check_cases[20].upper_bound’)
> > 57 | ((t) (! TYPE_SIGNED (t) \
> > | ^
> > tst-timespec.c:48:20: note: in expansion of macro ‘TYPE_MAXIMUM’
> > 48 | #define TIME_T_MAX TYPE_MAXIMUM (time_t)
> > | ^~~~~~~~~~~~
> > tst-timespec.c:290:19: note: in expansion of macro ‘TIME_T_MAX’
> > 290 | .upper_bound = TIME_T_MAX, .lower_bound = 1, .result = 1,
> > | ^~~~~~~~~~
> >
> > So maybe we need some more DIAG_* macros here now?
>
> No, since (a) this is a plain error, not a warning that's turned to an
> error by -Werror, so DIAG_* can't help, and (b) it's a definite compiler
> bug that needs to be fixed in GCC.
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103031
Thanks for explaining.
For now I am just adding a cast using (double) to work around this. A recent
rebase has introduced an abort localplt symbol into libc.so, so
build-many-glibs.py is not clean for me anylonger.
Once I track that down I should be good to submit v2 of the port for review.
-Stafford
prev parent reply other threads:[~2021-11-02 4:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 20:49 Stafford Horne
2021-10-27 22:13 ` Joseph Myers
2021-10-27 23:19 ` Stafford Horne
2021-10-28 17:15 ` Joseph Myers
2021-10-28 21:17 ` Stafford Horne
2021-10-28 21:45 ` Joseph Myers
2021-10-28 22:18 ` Stafford Horne
2021-10-29 9:05 ` Stafford Horne
2021-10-29 14:43 ` Joseph Myers
2021-10-29 15:08 ` Stafford Horne
2021-10-30 8:56 ` Stafford Horne
2021-11-01 20:47 ` Joseph Myers
2021-11-02 4:18 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYC8B61O+ZTRi9Qh@antec \
--to=shorne@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).