From: Mike Frysinger <vapier@gentoo.org>
To: Sam James <sam@gentoo.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3] configure.ac: fix bashisms in configure.ac
Date: Tue, 22 Mar 2022 21:53:55 -0400 [thread overview]
Message-ID: <Yjp9szjH7LPaVifB@vapier> (raw)
In-Reply-To: <20220322173309.2024872-1-sam@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On 22 Mar 2022 17:33, Sam James via Libc-alpha wrote:
> configure scripts need to be runnable with a POSIX-compliant /bin/sh.
>
> On many (but not all!) systems, /bin/sh is provided by Bash, so errors
> like this aren't spotted. Notably Debian defaults to /bin/sh provided
> by dash which doesn't tolerate such bashisms as '=='.
>
> This retains compatibility with bash.
>
> Fixes configure warnings/errors like:
> ```
> checking if compiler warns about alias for function with incompatible types... yes
> /var/tmp/portage/sys-libs/glibc-2.34-r10/work/glibc-2.34/configure: 4209: test: xyes: unexpected operator
> ```
lgtm, pushed!
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-03-23 1:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 23:03 [PATCH] configure.ac: fix bashism " Sam James
2022-03-22 12:46 ` Adhemerval Zanella
2022-03-22 17:15 ` Sam James
2022-03-22 17:33 ` [PATCH v3] configure.ac: fix bashisms " Sam James
2022-03-22 17:45 ` Adhemerval Zanella
2022-03-23 1:53 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjp9szjH7LPaVifB@vapier \
--to=vapier@gentoo.org \
--cc=libc-alpha@sourceware.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).