public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Xiaoming Ni <nixiaoming@huawei.com>,
	cltang@codesourcery.com, libc-alpha@sourceware.org,
	brooks@gcc.gnu.org, ppluzhnikov@google.com, neleai@seznam.cz,
	marat@slonopotamus.org
Subject: Re: [PATCH] elf: Sort only uninitialized objects in _dl_map_object_deps()
Date: Tue, 13 Sep 2022 05:42:18 -0400	[thread overview]
Message-ID: <YyBQes3cR0bso/2J@fedora> (raw)
In-Reply-To: <baf6c6e8-c9ba-c055-6bac-89df335cd346@redhat.com>

On Mon, Aug 03, 2020 at 02:37:22PM -0400, Carlos O'Donell wrote:
> On 7/29/20 9:56 AM, Xiaoming Ni wrote:
> > I'm trying to automate my test cases, but it's going to take a while.
> 
> Thank you for doing this.
> 
> My reminder to everyone is that writing tests is one of the most important
> things we can do as systems developers.
> 
> The systems we are building are expected to be very reliable and we need
> to write tests that encode our expectations and intent.
> 
> Chung-Lin's patches provide an automated way to write such test cases for
> the loader. Please try applying the patches and seeing if you can use the
> special DSL to write a test that matches what you were previously testing.

I'm walking out patch queue backwards in patchwork.

I wanted to note here that this 2020 patch has been superseded by
future work that improves the core DSO sorting algorithm.

We have switched to the new DSO sorting algorithm by default.

Please re-check the current glibc to see if it meeds your needs
or if we need to improve things further.

Cheers,
Carlos.

> -- 
> Cheers,
> Carlos.


      reply	other threads:[~2022-09-13  9:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-25 10:52 Xiaoming Ni
2020-07-25 20:57 ` Carlos O'Donell
2020-07-26 10:41   ` Chung-Lin Tang
2020-07-27  0:36     ` Carlos O'Donell
2020-07-29 13:56       ` Xiaoming Ni
2020-08-03 18:37         ` Carlos O'Donell
2022-09-13  9:42           ` Carlos O'Donell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyBQes3cR0bso/2J@fedora \
    --to=carlos@redhat.com \
    --cc=brooks@gcc.gnu.org \
    --cc=cltang@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=marat@slonopotamus.org \
    --cc=neleai@seznam.cz \
    --cc=nixiaoming@huawei.com \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).