From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: caiyinyu <caiyinyu@loongson.cn>, libc-alpha@sourceware.org
Cc: adhemerval.zanella@linaro.org, marcus.shawcroft@arm.com,
xry111@xry111.site
Subject: Re: [PATCH] aarch64: Standardized codes by using macro __glibc_{un,}likely and AARCH64_R
Date: Mon, 13 Mar 2023 09:07:01 +0000 [thread overview]
Message-ID: <ZA7ntb7SjnZsdBhM@arm.com> (raw)
In-Reply-To: <20230313031830.3597032-1-caiyinyu@loongson.cn>
The 03/13/2023 11:18, caiyinyu wrote:
> ---
> sysdeps/aarch64/dl-machine.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/sysdeps/aarch64/dl-machine.h b/sysdeps/aarch64/dl-machine.h
> index 4170b9269f..da4f08dec6 100644
> --- a/sysdeps/aarch64/dl-machine.h
> +++ b/sysdeps/aarch64/dl-machine.h
> @@ -83,7 +83,7 @@ elf_machine_runtime_setup (struct link_map *l, struct r_scope_elem *scope[],
> to intercept the calls to collect information. In this case we
> don't store the address in the GOT so that all future calls also
> end in this function. */
> - if ( profile)
> + if (__glibc_unlikely (profile))
> {
profile is unlikely, but this check only runs once
so i don't think this is useful.
the rest looks ok... but is there a reason to clean
this up now? there are many __builtin_expect in the
codebase and fixing them likely makes backporting
patches harder without much benefit.
prev parent reply other threads:[~2023-03-13 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 3:18 caiyinyu
2023-03-13 9:07 ` Szabolcs Nagy [this message]
2023-03-13 12:11 caiyinyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA7ntb7SjnZsdBhM@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=libc-alpha@sourceware.org \
--cc=marcus.shawcroft@arm.com \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).