From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>,
Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
kirill <kirill.okhotnikov@gmail.com>
Subject: Re: [PATCH v3 4/5] math: Improve fmodf
Date: Thu, 16 Mar 2023 23:22:18 +0000 [thread overview]
Message-ID: <a0e3493f-d4c-b9b5-13df-55c79c9862f8@codesourcery.com> (raw)
In-Reply-To: <20230316205629.835333-5-adhemerval.zanella@linaro.org>
On Thu, 16 Mar 2023, Adhemerval Zanella via Libc-alpha wrote:
> diff --git a/math/libm-test-fmod.inc b/math/libm-test-fmod.inc
> index 6d3cdda4fe..4b77b54736 100644
> --- a/math/libm-test-fmod.inc
> +++ b/math/libm-test-fmod.inc
> @@ -226,6 +226,11 @@ static const struct test_ff_f_data fmod_test_data[] =
> TEST_ff_f (fmod, -0x1p1023L, -0x3p-1073L, -0x1p-1073L, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> TEST_ff_f (fmod, -0x1p1023L, 0x3p-1022L, -0x1p-1021L, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> TEST_ff_f (fmod, -0x1p1023L, -0x3p-1022L, -0x1p-1021L, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> +#else
> + TEST_ff_f (fmod, 0x1.3a3e6p-127, 0x1.8b8338p-128, 0x1.d1f31p-129, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_ff_f (fmod, 0x1.3a3e6p-127, -0x1.8b8338p-128, 0x1.d1f31p-129, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_ff_f (fmod, -0x1.3a3e6p-127, 0x1.8b8338p-128, -0x1.d1f31p-129, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_ff_f (fmod, -0x1.3a3e6p-127, -0x1.8b8338p-128, -0x1.d1f31p-129, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> #endif
These new tests should be valid for all formats supported by glibc, so not
restricted to TEST_COND_binary32 (which would be the effect of that
#else).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2023-03-16 23:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 20:56 [PATCH v3 0/5] Improve fmod and fmodf Adhemerval Zanella
2023-03-16 20:56 ` [PATCH v3 1/5] benchtests: Add fmod benchmark Adhemerval Zanella
2023-03-16 20:56 ` [PATCH v3 2/5] benchtests: Add fmodf benchmark Adhemerval Zanella
2023-03-16 20:56 ` [PATCH v3 3/5] math: Improve fmod Adhemerval Zanella
2023-03-16 23:23 ` Joseph Myers
2023-03-16 20:56 ` [PATCH v3 4/5] math: Improve fmodf Adhemerval Zanella
2023-03-16 23:22 ` Joseph Myers [this message]
2023-03-16 20:56 ` [PATCH v3 5/5] math: Remove the error handling wrapper from fmod and fmodf Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0e3493f-d4c-b9b5-13df-55c79c9862f8@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=kirill.okhotnikov@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).