From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>,
Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
kirill <kirill.okhotnikov@gmail.com>
Subject: Re: [PATCH v3 3/5] math: Improve fmod
Date: Thu, 16 Mar 2023 23:23:34 +0000 [thread overview]
Message-ID: <ce2aa24-a1f2-7576-4e39-717dbca95ab@codesourcery.com> (raw)
In-Reply-To: <20230316205629.835333-4-adhemerval.zanella@linaro.org>
On Thu, 16 Mar 2023, Adhemerval Zanella via Libc-alpha wrote:
> +#if TEST_COND_binary64
> + TEST_ff_f (fmod, 0x0.cded0a47373e9p-1022, 0x0.3212f5b8c8c16p-1022, 0x0.05a1336414391p-1022, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_ff_f (fmod, 0x0.cded0a47373e9p-1022, -0x0.3212f5b8c8c16p-1022, 0x0.05a1336414391p-1022, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_ff_f (fmod, -0x0.cded0a47373e9p-1022, 0x0.3212f5b8c8c16p-1022, -0x0.05a1336414391p-1022, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_ff_f (fmod, -0x0.cded0a47373e9p-1022, -0x0.3212f5b8c8c16p-1022, -0x0.05a1336414391p-1022, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> +#endif
Similarly, these tests should be valid for all formats with at least the
range and precision of binary64 (i.e. !TEST_COND_binary32), not just for
binary64.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2023-03-16 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 20:56 [PATCH v3 0/5] Improve fmod and fmodf Adhemerval Zanella
2023-03-16 20:56 ` [PATCH v3 1/5] benchtests: Add fmod benchmark Adhemerval Zanella
2023-03-16 20:56 ` [PATCH v3 2/5] benchtests: Add fmodf benchmark Adhemerval Zanella
2023-03-16 20:56 ` [PATCH v3 3/5] math: Improve fmod Adhemerval Zanella
2023-03-16 23:23 ` Joseph Myers [this message]
2023-03-16 20:56 ` [PATCH v3 4/5] math: Improve fmodf Adhemerval Zanella
2023-03-16 23:22 ` Joseph Myers
2023-03-16 20:56 ` [PATCH v3 5/5] math: Remove the error handling wrapper from fmod and fmodf Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce2aa24-a1f2-7576-4e39-717dbca95ab@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=kirill.okhotnikov@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).