From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Siddhesh Poyarekar <siddhesh@gotplt.org>,
GNU C Library <libc-alpha@sourceware.org>,
Szabolcs Nagy <szabolcs.nagy@arm.com>
Subject: Re: tst-dso-ordering* failing on aarch64 with --enable-static-pie
Date: Tue, 16 Nov 2021 15:13:58 -0300 [thread overview]
Message-ID: <a2b0bcb7-629d-7518-136a-4e7a9fe3ef93@linaro.org> (raw)
In-Reply-To: <00aed799-a7f4-f573-8abe-f8a890994a48@linaro.org>
On 16/11/2021 11:23, Adhemerval Zanella wrote:
>
>
> On 16/11/2021 11:11, H.J. Lu wrote:
>> On Tue, Nov 16, 2021 at 5:50 AM Adhemerval Zanella via Libc-alpha
>> <libc-alpha@sourceware.org> wrote:
>>>
>>>
>>>
>>> On 16/11/2021 10:47, Siddhesh Poyarekar wrote:
>>>> Hello,
>>>>
>>>> It looks like ordering related tests are failing on aarch64 with glibc built with --enable-static-pie. Anyone wants to take a look at this?
>>>>
>>>> The full build log is here:
>>>> https://kojipkgs.fedoraproject.org//work/tasks/6697/78946697/build.log
>>>>
>>>> Thanks,
>>>> Siddhesh
>>>>
>>>>
>>>> =====FAIL: elf/tst-bz15311.out=====
>>>> FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>> =====FAIL: elf/tst-bz15311.test-result=====
>>>> FAIL: elf/tst-bz15311
>>>> original exit status 1
>>>> =====FAIL: elf/tst-dso-ordering1.out=====
>>>> FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>> =====FAIL: elf/tst-dso-ordering1.test-result=====
>>>> FAIL: elf/tst-dso-ordering1
>>>> original exit status 1
>>>> =====FAIL: elf/tst-dso-ordering10.out=====
>>>> FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>> =====FAIL: elf/tst-dso-ordering10.test-result=====
>>>> FAIL: elf/tst-dso-ordering10
>>>> original exit status 1
>>>> =====FAIL: elf/tst-dso-ordering2.out=====
>>>> FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>> =====FAIL: elf/tst-dso-ordering2.test-result=====
>>>> FAIL: elf/tst-dso-ordering2
>>>> original exit status 1
>>>> =====FAIL: elf/tst-dso-ordering3.out=====
>>>> FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>> =====FAIL: elf/tst-dso-ordering3.test-result=====
>>>> FAIL: elf/tst-dso-ordering3
>>>> original exit status 1
>>>> =====FAIL: elf/tst-dso-ordering4.out=====
>>>> FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>
>>> I will take a look. It is strange that the GLIBC_TUNABLES=glibc.rtld.dynamic_sort=
>>> is also failing because it is the previous algorithm.
>>
>> Please try the current master. It may have been fixed.
>
> Yes, that's my first though about this report. I am running make check on 128 core
> aarch64 machine.
>
It is due my dl-minimal-malloc change (b05fae4d8e34), which requires the same
fixed done by 47618209d05a:
diff --git a/elf/dl-minimal-malloc.c b/elf/dl-minimal-malloc.c
index 939b5271ca..ea9bca26cf 100644
--- a/elf/dl-minimal-malloc.c
+++ b/elf/dl-minimal-malloc.c
@@ -17,6 +17,11 @@
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
+/* Mark symbols hidden in static PIE for early self relocation to work.
+ Note: string.h may have ifuncs which cannot be hidden on i686. */
+#if BUILD_PIE_DEFAULT
+# pragma GCC visibility push(hidden)
+#endif
#include <assert.h>
#include <string.h>
#include <ldsodefs.h>
I will run a make check on aarch64 and x86_64 and push the fix.
prev parent reply other threads:[~2021-11-16 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 13:47 Siddhesh Poyarekar
2021-11-16 13:49 ` Adhemerval Zanella
2021-11-16 14:11 ` H.J. Lu
2021-11-16 14:23 ` Adhemerval Zanella
2021-11-16 18:13 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2b0bcb7-629d-7518-136a-4e7a9fe3ef93@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).